Details
-
AboutPrint(me.toString())
-
SkillsPython, C/C++, Java, C#, JS
-
LocationDen Haag
-
Github
Joined devRant on 5/4/2017
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
Umbrello. There is no neater way of drawing a diagram than "programming" it :)
-
This is hilarious. I can't stop laughing. This can't be real xD
-
@github sure. Let me see :)
-
Interesting. In some other countries of the EU that salary is illegal. That shows how relative things are.
Congratulations man! :) -
It would be much better if you had a cat though.
- cat sit
+ ??
- sudo !!
+ file "sit" does not exist. -
@kaguo but in C you don't need to use an external library, just use pointers and at some point the whole thing will blow up for sure ;)
-
@gears return _out or False
What i mean is that, the multiple line version has an issue that will make it crash when _out == None -
That's much better than:
return _out
because when _out == None, it will blow up because r is not declared.
Happy debugging :D -
Hahahaha what an idiot. "Writing a bomb" in Python xD
Everybody knows that bombs are programmed in C. Duh -
I've loved in the hague for years.
I'm leaving on Saturday. Just my luck. 😂 -
Wow
-
@github Ok cool. I will check the issues
-
Oh! one thing that I did change in travis.yml is to add more versions of python (travis will test 2.7, 3.3 and 3.4), and also a couple of versions of pypi. I moved the packages from travis.yml to requirements-dev.txt so that it's easier to install them manually (pip install -r requirements-dev.txt); if there is a new requirements for the tests, we can add it there.
@github it's your project and you are on change, so if you disagree with some of these changes let me know so we can discuss :) -
So, I didn't realice that @goojal was working on Travis already, so I did too. Luckily we came up with almost exactly the same .travis.yml haha. I sent a pull request @github. At first my pull request had conflicts with your changes but I just merged it all together and resolved those conflicts and everything seems to work fine (and so Travis says ;).
I also introduced some small changes to the structure. Like for example, I put some classes together in the same module, which is the recomendation from python (coming from Java, it's counter intuitive, but this is the Python way haha). Besides that, I just added a few tests for the models.
I look forward to your comments! -
Tell me what you think about those changes and I will work on them tomorrow (it's 1:40 where I live ;)
Cheers, and again, good Job!
PS: is there any other channel where we can communicate? -
- In this case, pirant.app is so small that can be inside __init__.py. This is a common practice and it would allow you to do:
>> from pirant import DevRant
instead of
>> from pirant.app import DevRant
If not, at leat __init__.py should import app.
- The test files should start with test_X so that nosetests (or other runners) can identify the test files
- Modules can be combined. I used to write one file per class too in the past, but the "pythonian" way is to write all the classes that are related into one module (file). Some small pypi packages are written entirely in the __init__.py. But that's not very important for now.
- By default, I use python3, although I am creating virtual environments for python2 and python3 so that I can test both. There are a few lines that will give errors in python3: some imports should be relative and the print statements should have brackets(). -
@github I cloned the repo and tried it. First of all, good job :)
I had to do a few tweaks on the unit tests to make them work. Do you use nosetests to run the tests? And if not, what do you use?
Travis is very easy to setup, but (IMHO) travis with python doesn't make much sense if you don't run tests, because you won't get any errors until you run the tests; that's why I started with the unit tests.
I have quite a few comments on the structure of the project. I'll send you pull requests tomorrow, but for now (continues): -
Cool! I'm in! I've worked with PyPi before, and with travis too (although for a java project).
What needs to be done? I don't want to step on eachothers feet -
@iSwimInTheC octopussy*
-
Don't forget to change your password! Hahaha
-
I actually laughed at this. Good one sir xD
-
Nobody is hot enough to be the single reason to learn JS. Too much pain. Also, if JS turns her on, she must be into some BDSM shit or worse. Run a way man!
Disclaimer: I know JS is a neccesary evil, but it still sucks xD -
That's great @Ashkin. I know it's not fun to break commits. Congratulations for your project!
-
Mother of God. That's going to be a huge commit. You should try to make more smaller commits.
Who am I kidding. Been there, done that 😂 -
I believe that originally it was called "The Facebook". She is not wrong ;)
-
@FintinaM
-
DTI;TLWRL
(downloaded the image; too long, will read later) -
Turbo C?? That poor ball is going to die within days from your stress!
-
@jpichardo thanks bro!
*sniffs in spanish* -
If you are thinking about ever cheating on her... can i have your laptop? (assuming it's not used as the murdering weapon)