17

First Rant here.

So I was working on some integration test issues when I found this by accident made by a professional level SW engineer:

@Test
public void testMethod() throws ApiException {
Response res = null;
try {
res = serviceToTest.callMethod();
} catch(Exception e) {
assertNull(res);
}
}

Was wondering why tests were being green after some code changes I've made cuz tests could have not been green afterwards.

Together with a senior (I'm also professional only) I've tried to explain him for a good 1-2hrs why this code is useless and he still did it. Good thing there are no errors in the real implementation from him after fixing the tests as it's code freeze here and we are having go live in a few days 🙃

Also luckily he isn't working on our code anymore and has only been doing so for a few weeks.

Wasted a day with it and gonna check all of his code now before I run in the next surprise.

Comments
  • 2
    @teganburns thank you 😄 was lurking for a while and really starting to love this community! It's hard to find nice communities nowadays
Add Comment