Learn More
Resend Email
7
myss
12h

Genuine question, what was the most comments you've left in a single code review?

Just reviewed pull request submitted by a developer working for a contractor company and needed to leave 70 comments. Seventy.

Opened LinkedIn and saw a post from that same developer saying he left the contracting company an hour ago. I still can't believe it.

rant

question

code review
Favorite
Ranter
Comments
  • 2
    12h
    Good for you. That's more than I ever left on a single PR. I hope there were a lot of changes...
  • 4
    12h
    40 to 50 comments on a PR which spanned 50+ files

    Did he leave because you left that many number of comments? Or he worked on this change after he decided to leave?
  • 4
    12h
    What kind of comments were those? Something that should be dealt with by a linter? Or was the PR just too big?
  • 3
    10h
    I quit after 20 comments or so and will just do a second review after that's fixed. Imagine reviewing all your requested changes again at once. Imagine reviewing 70 changes. That's some serious work and hard to do without mistakes
  • 1
    10h
    makes sense

    seen that before. someone does a shit job cuz they know they don't care and gonna leave. ofc they won't tell anyone and you're left treating them like they're retarded and they're more work than they should be because of their "attitude". sigh
  • 2
    10h
    needs context.

    70 comments on 3 lines of code is catastrophic, 70 comments on 3000 lines is okay-ish.
  • 0
    7h
    I mean a lot of comments is okay if justified. But the comments "you suck" and "wtf is this shit?" are not really necessary.
  • 2
    5h
    @Demolishun but WTF/min is the only reliable measurement of code quality.
  • 0
    5h
    @electrineer I guess its the difference between slander and libel.
  • 0
    1h
    If 1 on 1 reviews count , about 2h
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment