25

Told juniors about coding guidelines that don't put another if-else just to fix a bug. Think through about it and see if you can come up with better solutions.

Today one bug was filed, they asked what happened, one junior said that he [my name] asked me for no if-else in code. He kinda deleted all if-else in codebase and started using same implementation for everything.

I'm standing with a WTF face.

😐

Comments
  • 3
    Well atleast he followed your instruction 😳
  • 1
    The universe has a way with making great idiots
  • 2
    You shouldn't govern by fiat. It is much easier to change the habits of juniors if you let them figure it out. You should never assume what you say will be interpreted the way you mean it. The statement you made is quite generic and open to interpretation, if one of the juniors was insecure, he would have taken it as a criticism, hence the extreme end result. I believe you were advising your team to minimise branching and if the issue required an upstream change, they should seek further assistance. Remember, they're juniors, they're too scared to mess around with code that "works".
  • 3
    @C0D4 well no, he was told not add another if else just to fix a bug, not to remove any and all if else statements in the entire codebase :P
  • 0
    Hahahahahaha, some people lack common sense 😂😂
  • 1
    Lol. Kinda like my ex boss, when she asked my project password and I told her ShutDf@k@p. 😂😂😂
  • 0
    @ymas hmm, I'll take care of this in future. Actually he developed this service under direction of another senior dev. That guy left company because he was frustrated with management. So, in those times, he just approved every code-review without much attention.

    There code is very buggy, and everytime a new bug gets filed, he put another condition-check in codebase. Now I'm assigned senior dev for that service, so as a starter I gave so called 'guidelines'.

    I'll keep your advice in mind... This is going to be tough journey.😓
  • 0
    @thatJavaGuy are you looking for any (remote) freelancer, I'm not senior nor junior 😂
  • 0
    @ziadkiwan haha, no. I'm only an employee.😀
  • 0
    @thatJavaGuy i just want it for experience 😂, idgf about money 😂
Your Job Suck?
Get a Better Job
Add Comment