Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
I have a reverse case in my workplace. A senior guy in my team decides that every argument passed to any method should be an interface, even when it's just some config values taken from env. It's really easy to lose track reading code this way. But he would argue it's the Clean Code way to do stuff...
-
@Xamenyap This is a ridiculous interpretation of clean code. But I kind of see where this is coming from. I have my little theory that Uncle Bob has an irrational fear of modifying already existing code. He doesn’t like to break binary contracts, so every interaction between classes must be wrapped in dependency inversion. Open/closed princle is not only weird, but it is fundamentally wrong nowadays. To quote Dan North: „When requirements change, the existing code is now wrong! So replace it with code that works”
https://speakerdeck.com/tastapod/... -
@Root good luck replacing me the new replacement wont be able to do nothing in this mess lol
-
@matste I remember uncle bob specifically said that it's impossible to keep your code exactly as it is when requirement change, but you still should use the open close principle as a general discipline to make your code cleaner
-
@MegatonSettler Management doesn't know that, or care. They'll just hire someone else and yell at them until there's results. If they fail to produce results quickly enough, management will find another replacement.
It's a cynical view, but so very often it's true. -
@Root you are right, I'm not saying otherwise
when your code is a mess but everything work out in the end
When you keep getting +1s on a rant you posted a month ago.
I don't want to write clean code anymore :(
I read Clean Code, Clean Coder, and watched many uncle bob's videos, and I was able to apply best practices and design patterns
I created many systems that really stood the test of time...
Management was kind enough to introduce me to uncle bob clean code in the first place, letting us watch it during work hours. after like one year, my code improved 400% minimum because I am new and I needed guidance from veterans...
That said, to management I am very slow, compared to this other guy, they ask me for a feature and my answer would be like "sure, we need to update the system because it just doesn't support that right now, it is easy though it would take 2 days tops"
they ask the same thing for the other guy : "ok let me see what I can do", 1 hour later, on slack, he writes : done. he slaps bunch of if-statement and make special case that will serve the thing they asked for.
oh 'cool' they say -> but it doesn't do this -> it needs to do that -> ok there is a new bug,-> it doesn't work in build mode-> it doesn't work if you are logged in as a guest, now its perfect ! -> it doesn't work on Android -> ok it works on android but now its not perfect anymore.
and they feel like he is fast (and to be fair he is), this feature? done. ok new bugs? solved. Android compatibility ? just one day ... it looks like he is doing doing doing.
it ends up taking double the time I asked for, and that is not to mention the other system affected during this entire process, extra clean up that I have to do, even my systems that stood the test of time are now ruined and cannot be extracted to other projects. because he just slaps whatever bools and if statements he needs inside any system, uses nothing but Singleton pattern on everything. our app will never be ready-for-business, this I can swear. its very buggy. and to fix it, it needs a change in mentality, not in code.
---------------
uncle bob said : write your code the right way, and the management will see that your code generates less errors, with time, you will earn respect even though they will feel you are slow at first.
well sorry uncle, I've been doing it for a year, my image got bad, you are absolutely right, only when there is no one else allowed to drop a giant shit inside your clean code.
note: we don't really have a technical lead.
-------------------
its been only two days since my new "hack n' slash" meta, the management is already kind of "impressed" ... so I'll keep hacking and slashing until I find a better job.
rant
management