Joined devRant on 7/14/2017
Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
I am not as open minded and patient and a good teammate as I thought I was. Also either I am the biggest asshole on the planet, or I am so unlucky that I meet all kinds of assholes in my workplace, both past and present.
What do you guys think of code review? It was supposed to find potential mistakes in your code base, and share your knowledge with your co-workers, right?
In fact I have very bad experiences with code review, not just with 1 company, but quite a few. Code review process always comes to something like this:
Reviewer: Hey, I don't like your solution A because of disadvantages A1. You should implement solution B, because of advantage B1 blah blah...
Me: Yes, it's true that solution B provides advantage B1, but at the same time introduces much more complexity to the code base than necessary, and has disadvantage B2. I am aware that solution A has disadvantage A1 but it is justifiable and easier to overcome than B2 imo. In fact, solution A also provides advantage A2 that you might not know...
Reviewer: No, you HAVE TO implement B because of advantage B1 blah blah *repeating why B1 is awesome again*
I feel like it's just people trying to shove their preferences down my throat. Either code review is useless, or the companies I work for do something very very wrong in code review. Anyway, it's really discouraging me fron participating in team discussions.7
My team is in charge of an old and huge monolith. Many times we have to write dirty hacks because otherwise we would need to rewrite lots of things just to make even 1 tiny addition.
- When my supervisor makes a hack: "yeah I know it's bad, but it's a shortcut that should temporarily satisfy the business now, we'll fix it later hahaha"
- When I make a hack: "it's a hack, can you not do that?"1
A girl I used to have a crush on suddenly contacted after 2 years because she still thinks of me as one of her "best friends", and was sorry that she "hurt" me. After a few minutes talking, I knew she just wanted to get her new website done... Go to hell you fucking bitch20
Best. Fucking. Title.
If you open a PR with such title/description, please consider changing your profession12
My team lead is off this week and I was selected to be the "acting team lead". So far I have attended 73648283 meetings. Please pray for me!2
Don't you hate it when your co-worker does dumb things, but thinks it's the "clean code" way?
The following is a conversation between me and a co-worker, who thinks he's superior to everyone because he thinks he's the only one who read the Clean Code series. Let's call him Bill.
Me: I think the feature we need is quite simple, our application needs to call this third party API, parse the response and pass it to the next step. Why do you need to bury everything under an abstraction of 4 layers?
Bill: bEcAuSe It'S dEcOuPlInG, aNd MaKe ThE cOdE tEsTaBlE
Me: I don't know man, you only need to abstract the third party api client, and then mock it if you want. Some interfaces you define makes no sense at all. For example, this interface only has 1 concrete implementation, and I don't think it will ever have another. Besides, the concrete implementation only gets the input from the upper layer and passes it down the lower layer. Why the extra step? I feel like you're using interface just for the sake of interface.
Bill: PrOgRaMmInG tO iNtErFaCe, NoT cOnCrEtE iPlEmEnTaTiOn!!!
Me: You keep saying those words, I don't think they mean what you think they mean. But they certainly do not mean that every method argument must be an interface
Bill: BuT uNcLe BoB blah blah blah...
Me: *gives up all hope*14
Boss: we follow scrum here
Me: yeah, tell that to those shitheads who call themselves "product managers" and throw whatever features they want at us at the middle of the sprint with a fixed deadline, not regarding the team capacity.2
- Every dev needs to connect to a remote server, and do the coding there because the bosses are afraid that we will "steal" their legacy spaghetti written by the CTO in 2006 (the current year was 2016-2017).
- There are no QAs, because "why do you devs need mommy to look after your codes?"
- Bosses think it's our duty to stay extra hours without overtime payment while talking bullshit about a culture that promotes work life balance. You receive no bonus for staying late, but if you leave work 15 minutes early, HR will have a serious talk with you the next day.
- Bosses require "evidence" when you submit a leave request. For example, you tell them you're taking a vacation, they'll ask you for a copy of airline tickets, hotel bookings, etc.
- Bosses spend a ton on hosting parties for the customers while we're using 6-7 year-old laptops
- The CEO loves firing people for ridiculous reasons. Once he considered firing a guy because the way he walks is funny11
So my co-worker refuses to use Interface in Go because he dislikes php and interface is "the php way to do things". Anyone with experience dealing with this kind of ignorance?17
Teach kids to love computer science first, the rest comes later.
When I was in uni, most of my pals don't know why they're in the class. How the fuck can you teach linked list implementation when most of the students don't seem to bother to understand what a variable is?
I've always thought companies not using any kind of vcs is a myth. Today I learned that one of my friends is working for such a company.6