I found such a treasure today in the production code.

Magento also does things like that when parsing JSON (using the standard PHP JSON parser because would be way too easy)

It also does this the other way around which led to a bug where it would return a bool when the string was either true or false.... But a string stating "true" or "false was expected by all other functions...

🤦

Yep I'm working on a project with this shit all over the place. They do this instead of using enums

@M3m35terJ05h or a simple ternary

@lazyDev I always see your comments, when do you even work? lol

@SatoshiNakamoto different timezones bruh

Make it a function and I do not see the issue.

@mundo03 isMandatory should be a boolean. No way to set a boolean to "treu"

@M3m35terJ05h oh, then git blame and burn the dev

Actually, thinking in JS '==', it solves tons of wrong convertion problems

but this man, @jschmold , has killed it to one line

@jschmold I suppose the right answer should be !!Boolean("false")

@melezorus34 welp it doesnt

I bet that snippet is repeated too. I'll never understand devs that do this crap.

I had once wrapped the isfile() function in isFile()

@HAliPunjabi i ain't phyton expert but can't you assign isfile to isFile ?

@melezorus34 never heard of that. But AFAIK I wanted to do some additional stuff along with isfile, hence the wrapper, but didn't implement the additional stuff 😂

I love the typecasting from strings to a boolean... but what a bad way to do so