c# - Here i am, sitting, refactoring, and asking myself why? WHY? - devRant

Ranter

Comments

9

devTea

24382

5y

I see you are working on my coleagues code as well
16

ddephor

4548

5y

I feel your pain.

My colleagues are one step further:
2

erandria

3107

5y

louis armstrong sang "what a wonderful world" right?...
well...

HE DIDN'T SEE THIS SHIT!
2

neriald

1465

5y

@ddephor yours is redundant but not magic number at least.
2

ddephor

4548

5y

@neriald This type of enum doesn't add any information, so no difference to magic numbers. So useless and additional waste of resources.
2

neriald

1465

5y

@ddephor oh did you mean the ambiguity of mode_1 and mode_2? I thought you meant ... = 0
1

gruff

563

5y

The number representing the 5th column in a data table really isn’t the problem but writing 8 lines of shite for something you can do in 2 is a different kind special
1

ddephor

4548

5y

@neriald Yes, MODE_1 MODE_2 is useless anyway, having it started with 0 just adds a bit of topping to the cake. You just don't know what it means.

It should be MODE_BEHAVIOUR_XY and MODE_BEHAVIOUR_WHATEVER, just meaningful.

Related Rants

devRant © 2021 Hexical Labs LLC
Privacy Policy | Terms of Service