Senior: I've been programming for a long time. I know JavaScript.

Me to myself: I've seen your code, it is shit.

Senior: (builds JSON with string concatination)

Me to myself: ...

What am I to do? The system is full of stuff like this, and minimal support from management to fix and rewrite.

  • 10
    wha a fucking piece of shit, sorry you're dealing with this
  • 17
    But what the hell? That isn't even JSON! JSON uses double quotes!
  • 4
    @ScriptCoded it's still js land, so probably doesn't need to, JSON.parse
  • 5
    Tell him, dont be disrespectful though.
  • 5
    @jesustricks the json format is way more strict than javascript.
    Double quotes needed, no trailing commas
  • 8
    If you do code reviews, just don't accept garbage code. You can improve code over time and keep it clean only by doing strict reviews.
  • 4
    oh, my eyes!
  • 2
    @Codex404 yes my brain stopped working for a second.
    so either a very irrestrictive json parser or this shit doesn't even run, im starting to think the latter
  • 5
    Oh boy
    Welcome to devRant btw
  • 7
    Senior != good developer
  • 2
    Fire him.

    Or barring that: rewrite a segment of his code in a tenth the lines. Some people just stop learning after awhile and need a literal kickstart to realize there are still things they don't know.
  • 3
    Seems like my coworker
  • 5
    "Senior" - 1 year experience, 14 years repetition. I cant be 100% sure from the screenshot that you're in JS land, but if you are show him JSON.stringify()
  • 0
    Rewrite that shit for the next dev ... Live im on 6 shiti projet and i try change my job....
  • 0
    Show him how to do it better.
  • 0
    Oh Lord does he even use JSON.parse or does he parse everything manually
  • 0
    @Llama Damn man, I cannot tolerate that kind of bullshit. Please change your team or job. You deserver better than that. I feel sorry for you
  • 1
    Fucking wow. Your senior dev needs a promotion to tea boy. That is the single most ingenious thing I've seen as a developer. A true pioneer
  • 0
    What. The... 😱😱
Add Comment