Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
5 weeks later: reviewed with 15 comments about codestyle
It's more frustrating when it's a library you want to contribute to for use in your own project! The number of times I've just ended up forking it and hosting my own version on Bintray...
That being said, I've found myself on the other side of the fence with this too - and I do sometimes take a while to get around to reviewing PRs, especially when it's not very clear what they're doing, what it achieves, and most of the diff is filled with whitespace and needless formatting changes..
CptFox14305d@AlmondSauce I tend to try to process merged early, my team has gotten me used to the "either merge quick or we'll make sure the merge tool makes you want to slap your future past self" paradigm. The more you wait, the more diffs accumulate.
Right now, what frustrates me is that I want to get onto bigger changes for the programs I have my PR for, but I'd like to rebase before that
@CptFox Internal merges, sure, I agree. But if someone creates a PR on my open source repo and it's not clear what it does, the benefits it brings are questionable, and the diff has whitespace changes here there and everywhere, it's likely to get left alone for a while. If it then transpires that it's too much faff to get it merged in later because the project has moved on, then so be it - it gets deleted.
Your Job Suck?
Take a quick quiz from Triplebyte to skip the job search hassles and jump to final interviews at hot tech firms
Get a Better Job