Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
LMagnus20575yIt's not quite at dramatic as you're all expecting but here's what happened.
I called a meeting to bring all the Devs in to talk about the issue, remind them of the reasons we have pull requests and the standards that we expect of them.
The Senior who approved the second one said he didn't realise the first request existed and didn't spot there were any issues. He clearly didn't review it properly but ok dealt with that.
The guy who caused this issue tried to justify it saying he needed to deliver the user story. I pointed out that is not the way we do delivery and highlighted the risks he was being to the project and the team. He accepted he was wrong. -
@LMagnus always nice to have a good result. People make mistakes. Owning up to them is the key.
Related Rants
Developer creates pull request.
I hold suggesting changes.
Developer creates new branch and new pull request with exactly the same commit.
Another Senior developer approves pull request.
This will be discussed tomorrow morning!
rant
cheeky
pull request