At my previous job a coworker left positive comments alongside any negative ones on my code. “Nice job here. Very clean”, or “nice use of X design pattern here!” Kinda made me look forward to his code reviews.

  • 0
    Perhaps that's a good idea, adding some compliments into the mix
  • 1
    Were these actual comments in the code or comments on the PR?
  • 0
    @Shardj we used Gerrit for code reviews. They were comments individual lines of code.
  • 0
    I also try to point out the good points in a code review, not just the bad points.

    If you focus on the bad points all the time then code reviews just become depressing
Add Comment