Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
@torpkev hah, that’s one way to put it, I guess just that this was the breaking point. Not ranting about it for the previous 1000 times, doesn’t it make me Mahatma Gandhi ??
-
@prabandham That guy is weird, every time we change technologies he gets skinnier.
-
Dude, this is *normal*, and nothing to do with languages or accents. I have PRs with changes like this requested all the time and don't give it a second thought, I also request similar changes to PRs that come my way.
It just means the permanent devs think some different wording would fit better with the project's style, and since they're the permanent devs ln that project, they're best placed to know. It's not an insult to anything Indian :/ -
@AlmondSauce a comment would suffice don’t you think ??
-
@prabandham Depends on the workflow. Some projects still use the "old school" mentality of each PR being distinct, accepted or rejected right there, and then a new one created with any requested changes.
-
@AlmondSauce oh believe me there are are a lot of legacy code which have worse choices of method names and variable names. That I have not even defined. If the point is to clean all of em, them that IMO should be a tech debt than a reject.
-
@AlmondSauce as a follow up. Even other peer PR’s have shitty (worse than that I have mentioned in my rant) naming convention.
-
@prabandham just because the rest of your codebase may be riddled with rubbish doesn't mean that you want new contributions to be too. Holding PRs to a high standard is a good thing, regardless of the state of the project.
-
@AlmondSauce true. But what is obnoxious IMHO is how the PR is treated. Considering how much care & heart that I put into the whole feature.
With extensive specs and code comments and what not.
I guess a whole lot of context is required to understand my stand. But what ever. This view of prospective can go on back and forth for ever !!! -
As for the topic, I agree with @AlmondSauce here that a shitty codebase is not a reason to continue adding shit and even small things like naming conventions can get messy later on. If you rename it later, then if someone has to hotfix an old release and the name changes that is confusing. Also later often means never, if it's not causing any issues.
In short: without context it is difficult to understand the issue here indeed. Not saying there is none - if your PRs are often flagged for things like this when those of others are not, then that definitely is an issue, at least for the PR reviews of the others. -
Had a call with Microsoft the other day to update my PC key, was a girl with a heavy Indian accent - took me an hour to change it because she had to keep repeating the letters as I had no fucking clue what she was saying.
They might have adopted English from someone else but its much clearer to understand than inglish. -
@Drmzindec you should have just shared your email ID and asked her to mail it to you.
I do know that not all Indian accents are clear to most. But the part of the accent was just a back lash as that has come up several times from that one person. (Rest are fine with it)
The main point of the rant was to showcase the indifference this guy has with my PR’s.
when your code is a mess but everything work out in the end
When you keep getting +1s on a rant you posted a month ago.
Go big or go home.
Fucking American tech lead rejecting PR because he wanted me to change disallow_some_feature to prohibit_some_feature 😡
FYI English was never your fist language either. It was because (from what I have read on the internet)
You did not have a first language just that you adopted it. And “called it your own”.
And you go on and and about Indian accent !!!
F*c*k accent. I’ll rant about your f*c*k*n* attitude. Guess time to change jobs.
BTW American based projects would do much better (in your f’ing opinion without this naming convention)
(This is not targeted at all Americans, I have had some good technical feed back as well. With some really good edge case catches which I over looked, this is meant for one f*c*i*n* project manager/Dev)
Double standards 😡😡
rant
fuck_dev_life
americans