To all the programmers calling “ToString()” on variables that are already of type String....

Please stop.

Brogrammer: *not sure if string, better call toString*

TheRestOfUs: (┛ಠ_ಠ)┛彡┻━┻

But my string isn't stringy enough, I need more string!

I feel like toString on strings should just be forbidden to be called by compilers and interpreters.

Although, in the case of JavaScript, lazy typing might prevent that from being a good practice.

@kescherRant
That would break encapsulation in unintuitive ways :) more a style thing in this case.

@SortOfTested Oh well, maybe I shouldn't design languages.

@kescherRant
Never know unless you try!

Perhaps there is a corner case where it returns a non-string. So it is a catch-all. Maybe it was easier than tracking down the corner case.

Kids : *calls toString() on objects*
Men: *calls toString() on String*
Legends: *Calls toString() on null*
Ultra legends : calls (""+null).toString()

It’s as disgusting as

if (true === booleanMethod())

"How about no?".ToString();

"fiber".ToString()

>> Output:

@C0D4 i've got a fever. And the only thing that can fix it, is more string!

NO.

Just making sure.

I call ToString() 3 times on each string, just to make sure it's a string. It's good practice.

IDE's flag that normally for me

@AlmondSauce It's not like that computer has anything better to do anyway...

Well if you could assign values to an element of a string we probably wouldn't have this shit.

"Yo dawg".toString()

(str: string) => String(„ToString“).toString()

What language? Does it have strict typing? Does it guarantee input not being null when strict typed? Or does it only cast zero characters for overloading purposes? Because e.g. C#:

> string s = null;

> IPAddress i = null;

> Console.WriteLine(object.Equals(s, i)); // prints "True"

> Console.WriteLine(object.ReferenceEquals(s, i)); // prints "True"

I understand the rant but it's not always obvious you have a string in the first place even if your IDE and static analyser claim you do. Also, `toString()` might be doing something different than what you think, e.g. presetting an overload without casting type so... all and all, it's safer to call that extra casting. Not saying I do it, I hate future-proofing. Saying I understand why experienced coders sometimes choose to do it.