Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
In my case, after I finish off the feature and hand it over for review the UX folks were like, I'm not sure this looks good and changed everything. PM stupidly accepts whatever designers say. I have to rewrite whatever I have been working for three months! #fml
This is why I think code reviews suck, are useless and a waste of time. I haven't ever got any feedback that would change anything in the way I work and if I always had to wait for my code to be reviewed, I'd be old.
@iamalchemist it sounds like you guys need design reviews before anything even gets written, there..
@dsteiner I've learned a lot from code reviews and so write better code from them, and they help maintain consistency across our repository. They're good, but only if the reviewers aren't absolute twats and only if you're given the power to say 'no thanks' to their comments.
Yes of course. If they are used properly to improve code and knowledge it's a great thing. But if not they are a waste of time.