Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
There is another thing here that if you're a junior (which of course you may not be), working faster doesn't always mean faster and better delivery.
If I choos between someone doing 10 PRs a month but puts thought into software design and builds something with good extension points, well testes for maintenance and refactoring, clean code Vs 100 PRs with just copy paste and no thought to design - so like just scripting over and over - I'd take the first guy every time. -
PRs are a terrible metric for performance - almost as bad as LoC or similar counts. I've had weeks where I've slacked a bit and done over 4 times as many as weeks where I've been working my arse off.
Some PRs are trivial, others require a huge amount of work. Some need lots of insight and collaboration, others are quick individual fixes. And some might just be dev-only affairs, whereas others can be tied to recreating a very specific scenario in a dev environment that takes weeks to reproduce.
Sure, you might genuinely be doing 4x as much work as anyone else, it can happen. But PR count is a terrible way to try to show it.
when your code is a mess but everything work out in the end
It changed my life, really. 😁
When you keep getting +1s on a rant you posted a month ago.
Appraisals are pretty insightful times. I wanted to check how much work I do as compared to others in the team. So, I tried to pull up number of pull requests created by me and others in the team. And to my surprise, I create 4x(I created about 850 pull requests) more pull requests than the next contributor(200 pull requests). I knew in general I was doing more work and much faster, but this is just too much.
I know number of pull requests is not an indicator for the amount of work done by anybody, but I had this feeling as well that I was doing more than others. I often see other members of the team not putting that much effort, and rather have a relaxed approach to getting work done. They pick one ticket and take the whole week to complete it slowly. While I hustle to get as much done as possible.
As far as the appraisals go, I am kind of laid back in terms of contributing towards overall organization which is now getting more weighted for my appraisal. So, despite me doing quite a lot of work, I am getting the appraisal at par with others in the team.
So, its kind of feels a little bit uncomfortable.
devrant
rant
appraisals
developer