14

PR reviews, people leave great comment, some suggestions and there could be a discussion.

But please don't be the person who goes there and add those weird and useless comments such: "CI failed, your PR is behind dev branch..."
That's the role of the provider(Github, Bitbucket.....) and adding that comment is just a waste of time.

This start to happen more often and I had to rant about it :D

Comments
  • 7
    *creates PR of a cool feature*

    *3 weeks passing by*

    DevLead: Your PR is behind dev, we need to merge this NOW, ASAP!

    Me: You fool!
  • 1
    @petergriffin that a good example haha :D

    It seems that you have a fun time also with waiting for your PRs to get reviewed.
Add Comment