Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
Someone, I have no idea who, commented on my personal project that he wanted to pick up one of the issues.
Then, he followed through and fixed it and sent a PR.
Feels good man.4 -
dev1: have you finished the task?
dev2: yep
dev1: why don't you open a PR?
dev2: I'll open one at 17:59. I want to sleep this night3 -
Got a PR that I had to approve named "projectfix_new". Told the person that we shouldn't use names such as "new" or "old" but it was OK this time. Later got a new PR named "projectfix_newer".6
-
Dev submitting PR: “Testing instructions: Self explanatory”
Dev reviewing PR: You need to be a bit more verbose than that.
Dev submitting PR: “Testing instruction: Feature should work as expected”
Dev reviewing PR: *sigh*… Feature doesn’t work as expected
Dev submitting PR: WHAT IS NOT WORKING AS EXPECTED??? I NEED MORE DETAIL THAN THAT!!
Dev reviewing PR: …….So do I you muppet5 -
Every time you squash a bug before someone else even sees it...
Lead: "There's a bug, you fix"
Me: "The PR for that has been waiting for your review since yesterday..."5 -
Manager: What’s taking so long on that PR?? It’s just some small styling adjustments
Dev: No it’s not you added an entire new calendar module that doesn’t work
Manager: Ok but besides that it’s just a small couple of css edits
Dev: You made styling changes in 50 files, half of which break our mobile responsiveness
Manager: Well then STOP talking to me and FIX IT if you’re so smart.
Dev: You also added a series of filters on a table in this same PR that cause th—
Manager: OK SO I GOT A BIT DISTRACTED THE FACT IS IT ALL NEEDS TO GET DONE SO IT DOESN’T MATTER IF IT’S ALL ON ONE PR SPLITTING THINGS UP INTO SMALL UPDATES IS JUST UNNECESSARY BUREAUCRACY AND IF YOU LIKE THAT THEN GO. WORK. FOR. THE GOVERNMENT!!!
Dev: …10 -
Reviewer: your pr has unit tests
Me: yes
Reviewer: well, we never had unit tests, this is kind of an issue, not sure how to handle this right now
return "LOL"8 -
It triggers me when Mac users commit .DS_store file on GitHub.
Its even more annoying when they dont merge my PR which deletes the .DS_store file8 -
Can we please all just appreciate how much more enjoyable the "cloud-to-butt" browser extension makes reading all those damn pr texts about "the cloud"? Seriously, try it!
4 -
The first time I ever did a PR on Github, I forked the repo, did the fix, committed the file and put the merge target to my fork master instead of the original repo master.
I then proceeded to accept my own PR and got so excited that it was so quick to merge.1 -
> make a change
> PR gets rejected
> IHATEFORALIVING! YOUR CHANGE IS NOT WORKING! EVERYTHING BREAKS!
> 3 hours long debugging session
> We find out a whole bunch of bugs
> Suddenly, everything works
> None of the bugs had ANYTHING to do with my change. In the instances where the app broke, my code wasn't even being called at all.
> My change was literally the one and only working thing
I wish life was like in The Office, when you just stop what you're doing and you drop the Jim stare at some camera
3 -
Dev: Your PR only addresses a quarter of the ticket
Dev2: *limps a commit so that now 1/2 of the ticket is addressed and creates a new PR for a separate ticket*
Dev: Your original PR only addresses half of the ticket
Dev2: *limps a commit so that now 3/4 of the ticket is addressed and creates a new PR for ANOTHER new ticket*
Dev: Your original PR only addresses 3/4 of the ticket
Dev2: *limps a commit so that now all of the ticket is addressed but two new bugs are introduced and creates a new PR for ANOTHER new ticket*
Dev: Your original PR introduces 2 new bugs
Dev2: *limps a commit addressing one of the two new bugs and creates a new PR for ANOTHER new ticket*
Dev: Your original PR still has one bu—
Manager: WOW GOOD JOB DEV2 THAT’S 5 PRs TODAY AMAZING! Dev you need to pickup the pace, you only have 2 PRs so far today. And get these PRs from Dev2 QA’d fast. He’s a rockstar!
Dev: …
*The 4 other PRs turned out to be equally dogshit*
Manager: Hey hurry up with QA, you’re holding Dev2 back!
Dev: …7 -
Manager: Hey Dev I need to do QA on this PR.
Dev: That PR is not finished yet
Manager: Well do QA now anyway, that way when it is finished it can be merged in right away since QA has already been done on it. It’s a project management technique called “fast-tracking” and it improves efficiency.
Dev: …9 -
Why have you not yet approved my PR?!!?!
The PR:
```
role.filter(elem => elem !== "view" ? elem !== "use" ? elem !== "admin" ? false : true : true : true)32 -
Me: Hans, Get ze Flammenwerfer!!!
Hans: Why?
Me: The fucker rejected my PR because "calling twice the same getter is a code duplication". I swear, he always tries to find something!3 -
My first PR approved for open source community. WOW !!!
It's felt like heaven. I'm done something useful 😍3 -
Colleague: Oh i've noticed your PR uses tabs instead of spaces, we use spaces, can you change yours please?
Me: ..... can you leave the building immediately, for your own safety21 -
Best. Fucking. Title.
If you open a PR with such title/description, please consider changing your profession
11 -
I submitted a PR on Eclipse Che, filed ECA, etc. etc.
It's not my first contribution however, I've been working on their dockerfiles repo for a while.
...then they merge my shit without waiting for QA...
excuse me what the fuck2 -
"PR rejected because you didn't do localisation"
"Wait, is that a requirement?"
"Yes"
"But there is no localisation in any of the 10 repos in this project!"
"Yes"
"So how do I know if I am expected to..."
"You don't, until I reject your PR"4 -
Want to piss off the person reviewing your PR?
don't just return true or false use 1 == 1 for true and 1 == 2 for false.
Watch the glorious rage unfolds 🤘🤘🤘6 -
Why the fuck contributing to opensource is so much pain. They get back to me after 8 months of my open PR. Sir, I don't remember a fucking thing I wrote...5
-
A PR I raised was left un-reviewed for 3 months. And finally when shit hit the fan, I was asked why I never worked on the fix.
I pointed to the PR I raised 3 months ago and I got absolutely flamed for it because obviously, it was my fault that I did my part, asked for a review and moved on to other tasks.
According to my manager, I should have kept pushing for the PR to be reviewed.
I wanted to set the office on fire that day.5 -
I'm reviewing a PR and it's easy to detect which functions were created with an AI: the ones that have comments.4
-
The fucking cunts didn't approve my PR because "it wasn't necessary to do it like this". My PR would have fixed some technical debt, but yes, fuck you too if it doesn't fit your shitty narrative.8
-
Slack Boss: hey, could you check work of dev that is okey, we want this update fast.
Me: hey, just tell him to open PR and assign me, I will check and merge changes.
Slack notification: Dev: Hey, could you please merge Pull request on the project ?
Me thinking, hmm weird, I didn't get email.
Checking github, 0 pull request.
Me: hey, I don't see any pull request open, and when you make pr, just assign me I will merge it right away.
Dev: takes half a day
Dev: Makes pr and assign correctly me.
Dev on slack: HERE is PR open now @me.
I get 3 notification to see this PR, sure at least it is there.
I check this PR, 50 commits, X conflicts, cannot merge this.
Me: Hey, @dev please fix conflicts in your PR.
DEV: takes another 2 days to respond.
Boss in the meantime: hey, have you pushed those new changes ?
Me: I am waiting for conflicts to resolve.
Dev: I fixed the conflicts @me.
I check the PR conflicts are there.
Me: are you sure you pushed your changes @dev ? I don't see them resolved
Dev: takes another day and pushes changes to resolve conflicts.
Me: merges PR to master becaus he based it on master, I will sync the developer branch myself.
All good, everybody happy.
I write to dev: Next time base your changes on develop branch and resolve conflicts before making PR.
Two weeks later new PR From this dev.
Based on Master, conflicts everywhere.8 -
> creates new PR for open source project
> runs tests locally before pushing
> pushes
> waits 8h (not kidding) for appveyor checks to complete
> tests failed
MOTHERF- -
Before we started a new project, as a team, we set some ground rules like: frequent, small, digestible PRs.
PR#1: 52 files (week 1)
PR#2: 107 files (week 2)
JUST FUCK OFF MATE!!!2 -
Today I was talking about merge conflicts with a group of devs. One of them asked if any of us had ever rushed to merge a PR before another dev could merge their PR, knowing there were going to be conflicts. Some were more ashamed to admit it than others, but in the end everyone was guilty of doing it at least once :)
Anyone ever do that to avoid being the one who has to resolve a conflict?2 -
When you review a PR from a senior dev, find something improvable, suggest it and the dev updates it accordingly.
The first time when this happened made me the luckiest guy. It's still rare, though.1 -
"Just created my PR. I finished the feature, and I've also reformatted the entire project at the same time so everything is clearer. Thought we might as well merge both at once."
😬😬😬4 -
Today my first ever PR on a community repo on Github just got merged!
I was always afraid to open a PR on any project because of my lack of self confidence. It's a really big milestone for me and I'm really proud to say that the code and the tests I wrote immediately got approved and merged into the main branch.2 -
So my PR for the JetBrains university repo got accepted and now...
YEEESS!
reposted because i was too dumb to cut out my full name
9 -
How the hell does PR containing production secrets and private keys gets 3 approvals and gets merged upstream? 😬 🥴6
-
*Makes a small change in Webpack generator for Eclipse Theia*
*Takes 10 minutes to complete all tests*
*PR*
*Travis CI builds*
*Takes 30+ minutes*
Uh, Travis, you okay?
-
So I made a PR into Keras after a loooong time. It ended up being merged as the 5000th commit of the repo. I'm so happy 😭
3 -
Just checked a pr I need to take care of tomorrow…
“Please review [other pr] first, this solves a bug the other one introduces”
…Ah yes. Stupidity.
“Already tested by QA, accept without comments or job will be wasted.”
… I need a vacation or a megaphone to make someone deaf by screaming in their ears again and again: “follow the fucking processes instead of making QA preapprove your shitty code.”2 -
Boss: we can't accept your MR request until you fix the problems we highlighted, everything is blocked and the client is getting angry
My brother in Christ, I understand your concerns but I need you to understand: you decided to block a perfectly working and documented PR because you didn't like having "<!-- -->" in a couple of HTML files and menial bullshit like that.
It may not be the most elegant thing ever but don't put on me the responsibility of your blocks or I'll smash your face with the coffee mugs I've used to work until midnight so that you could deliver the product in time after someone else delayed the deadline twice already.
Thanks and get fucked ASAP.3 -
CAN SOMEONE PLEASE TELL ME HOW TO TRANSLATE PULL REQUEST TO GERMAN?
According to one of my teachers I have to translate this in a coding guideline otherwise other devs might not be able to follow the procedure...
I asked him how he would translate it and he could not give me a proper answer... describe it he said...
How the fuck does it improve my guidelines if I describe PR!!!
And if your not capable of doing it better how should I know I have to do it!
Sorry I looked at an old exam and got triggered when I saw the correction21 -
For everyone happy to see Facebook getting negative PR, just remember, unless people decide that they are willing to pay a monthly subscription for social media, nothing is going to change long term.6
-
Bro every time this guy wants to create a PR, rather than branching off another branch and raising a PR to get it merged back in, this dude creates a fork and then makes a PR to merge the fork back in.
Holy. Fuck. Please don’t do this. It makes checking out your “branch” a massive pain in the ass. Plus, it’s totally unnecessary, and I can’t even check it out to begin with because your forked repo is fucking private you stooge. If we were in completely different orgs or doing open source I’d understand a fork. Not if you’re sitting right fucking next to me!!!!!11113 -
As much as I hate Amazon Alexa and everything connected to it, the randomly laughing thing is a very smart PR-move.5
-
I can't take this anymore...
I'm reviewing n-th PR and I wanna gouge my eyes rn. This is the example I found in one of the PRs (and I could enumerate the examples for a long time...)
Mother****er piece of sh*t.
11 -
> barges in
> slams massive unintelligible PR on the table
> fixes a bunch of tickets all at once
> won't explain how tf it works, it just does
> refuses to elaborate further
> leaves
9 -
Me: *Make a PR*
Seniors: *takes 5 days to review* This must be changed
Me: Okay. *Make changes and PR on same day*
Seniors: *takes another 7 days to review* Oh, you also need to change this
Me: really? Okay. *do the changes*
Seniors: Well, I'm gonna accept it. But maybe you should rework all the integration later.
Me: what.
I'm super tired of this shit.8 -
Got my first PR merged into a library for a new language(Elixir) I started working on!! Wah pah!! 😎1
-
Developer of said repo notices the influx of activity, but then just updates the readme by saying there are bugs, not fixing.
Bro I just gave you a PR. Take the fucking PR and that will fix the bugs. -
I made some changes in existing repo on my own branch. Created PR for it to be reviewed and merged into master.....
That was more than a week back. But senior engineer never merged it.
Today I see that he closed my PR, deleted my branch. He created his own new branch, added my changes and some of his changes and created PR.
What shit is this?5 -
Junior devs PR -
line 98: Catches FileNotFoundException.
line 99: Immediately throws FileNotFoundException
--
CHANGE REQUESTED 🤦🏻♂️ -
I made my very first pull request to a project of public interest.
It's just a paragraph in the React docs, but still.
I feel like a useful person.11 -
Manager’s PR Description: I made changes relating to a ticket which should work as expected. I also made various other changes as I saw fit, test whatever else I changed too.
Dev: …2 -
Sent my changes before everybody for code review, got git blocked because today was demo day, and ... And asshole guy merged his own PR without code review. That conflicted with my PR. I am going to start posting the shennanigans of asshole guy from now on, just to have a record of his stupidity.
10 -
Today I found this jewel in a PR of a respected dev of my workplace:
if(conditions)
{
return true;
}
else
{
return false;
}
3 -
When a PR merged to improve functionality breaks the functionality 🥳 and now I have to fix the FIX to fix it.2
-
Was looking through some repositories and found this in a 2y old PR, the only PR there is and ever was in the repo..
Ends with:
> Best wishes for the Wednesday launch.
> Steve
Steve never got an answer (on the PR at least) .. but the README links to his fork now (and no other changes have been done) .. why not just accept the PR or at least close it..7 -
What the FUCK is the point of submitting a PR, if you're going to approve my code, without looking at it, and then LEAVE ME to further refactoring.
I don't mind the refactoring. At. All.
What I DO mind, is being told "yerp, looks good" and then standing aside as I break everything.
TeAmWoRk5 -
Senior Tech lead keeps yapping about "we need more comments in the code"... Yeah right...
I reviewed his PR today:
# Get the feature list
builder.get_feature_list()
# Assign the features to the columns
target.columns = features
...
FFS15 -
Welcome to this week's episode of "sudo-woodo tries to get a single Python script merged", starring...
•The software architect so senior they were working here while I was still in pre-school. Wasn't added as a reviewer and was completely absent on this project for two months but came in on this PR with a few questions, including questioning design decisions they agreed on the last time they saw the project.
•The QA lead with ten years of experience... in Java. Has never even touched Python and asked to review, only for every issue raised but one stemming from not knowing the language.
•The CI guy. A script guru who will find a problem with literally anything. Honestly the most helpful person of the bunch.
•My coworker. Hasn't said anything yet.
please send help -
Fuck, I keep missing PRs and comments, because github doesn't notify if you're not directly tagged, is there some better way to get notified about things like new PR on your repos or generally notifications?12
-
Sometimes I like to look at my PR and think "Damn, that's some beautiful code, I can't wait for someone to review it".
Then the review comes and see a bunch of requested changes. =/5 -
In some unpredictable turn of events, ignoring my PR for 6 months will cause said code to not be aligned anymore with develop.
And it gets wilder: if you reject my PR for this retarded bullshit, I may not react in the civilest of ways.2 -
One of the best feelings is when you're reviewing PRs, leave a comment of an issue you're seeing & another developer supports & agrees your comment, so the original creator of the PR doesn't think you're making things up.
-
So, for the past...what, week or so? I've been working on a side project with @gianlu. It's the PretendYoureXyzzy fork - our attempt to rejuvenate an old shitty piece of software.
I had started working on a fork alone, and then he asked to team up so I was like "Sure, I got nothing better to do." So, he's working on the backend (and hooking JS up to the backend) and I'm developing the frontend.
I don't know why I thought tech would stand still. Google says they're putting MDL on life support and replacing it with a much more complex successor, MDC. It's not hard to use, but what really bugs me is the lack of notice on getmdl.io. If you are switching to another project as your main focus, why the fuck wouldn't you advertise in the most places possible?
Granted, I don't do web design and/or development on the daily. Yes, I can do it, but I'm not always as up-to-date with web technologies as I'd like to be.
However, the screencap captured is the third time I've taken the knife to the UI. MDC is great tooling, at least to me. That dialog? Not something MDL would've had out the box on the first day. You'd have to work for that.
I don't have an issue with MDC, I have an issue with the lack of PR around it.
6 -
Just merged a PR, all checks were green and it was reviewed and approved by me and another dev.
Had a great big ‘do not merge’ label on it...
fml whoops -
I once made a pull request fully aware that 3 tests were failing. The PR was approved and merged.
In my defense, they were very complicated tests and I fixed them a few days after.2 -
Not claiming any originality here... I'm just happy to finally have included it. We'll see if it passes PR review - might make my coworkers "steam" a little (pun intended) ;)
2 -
*Assigns coworker as reviewer for a PR*
*Reviewer comments on something he thinks should be changed*
*Reviewer realizes I went home as it is Friday afternoon*
*Reviewer is super impatient, and chooses to push the change himself. He then accepts the PR (his own code) , merges, and makes a release*
*Team lead starts yelling since an obvious bug made it to prod - Literally white frontpage*
*Reviewer blames me, since the bug comes from my PR*
... Thanks, former employee. F*cking thanks. I know you got fired for being a d*ck, but I hope karma kicks you in the butt for the rest of your life..
And ps. to you: Don't blame coworkers when you can check the history.
F*ck some people..4 -
PR reviews, people leave great comment, some suggestions and there could be a discussion.
But please don't be the person who goes there and add those weird and useless comments such: "CI failed, your PR is behind dev branch..."
That's the role of the provider(Github, Bitbucket.....) and adding that comment is just a waste of time.
This start to happen more often and I had to rant about it :D2 -
You know its a good end of the work week, when you feel compelled to mention the Geneva convention in your last PR before logging off :)3
-
Got a nice PR merged. Happy because it's on a popular project with over 4k stars. Ashamed because 50% of the commits are changing indentation from 4 spaces to tabs 😌1
-
PR comment: You don't need this useCallback and this useMemo, it's premature optimization, this component will not have a lot of rerenders anyway.
*remove it and merge it*
Few weeks later...
Slack message: why the app is so slow???
*opens a PR putting back all "premature" optimizations*
PR comment: Hum... I don't think that's it, but let's try it.
*merge it*
*slowness is gone*
Slack message: wow! How did you figured out so quickly???
Me: I was lucky, I guess ¯\_(ツ)_/¯2 -
So they are back, wanting another quick PR approved.
The PR:
```
let isDisabled = switch quantity > 0 {
| true =>
switch value !== "" {
| true => false
| false =>
switch inputStatus {
| Valid =>
switch inputData {
| Ok(a) => a !== 0.0 ? false : true
| Error(_) => true
}
| _ => true
}
}
| false => true
}
```6 -
When you finish writing your PR and just a minute or so later it's reviewed / merged!
Ｉｓ ｔｈｉｓ ｈｅａｖｅｎ？2 -
So.. I have raised a PR 2 weeks ago.. it needs approval from 2 of the senior Devs on my team. The first one reviewed it within 3 days, without having to follow up. Then comes the second one, who is senior than the first one. I have been following up with him on a daily basis for the past 1.5 weeks, each time I request him to review my PR he sends me a "sorry" followed by a stupid smiley. I have tried tagging him on Jira, setting up a meeting with him to get it done, nothing's working out. He has already looked at the code and I have explained him the code and the context, but he is just not adding comments/approving/rejecting the PR. I have missed the release date for the feature because of his lack of concern and petty excuses. So done with him.3
-
* Sigh * Found this in an open source project, time to make a PR that'll never get looked at. \
(first and last lines)
8 -
Commented on bit bucket to a PR about a missing @para. Hit submit and bam everyone gets an email and sees the following. Turns out @param is someones handler:
1 -
Code review day 1:
Me: Where are these three templates being used? I don't see any class that uses them.
Him: Oh, yeah. My bad. I'll remove them.
(Time passes)
Him: I don't know what's going on with my branch. Please ignore the PR for now.
(Time passes)
Him: Is there any way for me to get the files from staging. I don't know what I did to my branch.
Me: Hang on. I'll push a copy of the one I have in a new branch.
He declines his PR and stops by to say he's going home but he'll open a new PR tomorrow and remove the unused files.
Code review day 2:
Him: Hey, do you know what happened to my PR? It looks like it disappeared.
Me: You declined it yesterday. Said you'd make a new one today without those extra files.
Him: Ooooh!1 -
Why is every innovation trying to go towards "replacing programmers"? like, what have we done to you?
GitHub CoPilot will replace programmers!
AI will replace programmers!
This/That tech will replace programmers!
Nobody says,
"Programmers work remote so we don't need to hire managers anymore!"
"Programmers wrote a monitoring script for progress tracking, so no need for managers anymore!"
"We are asking people to install sprinklers everywhere so we don't need firefighters!"
"We can just have one teacher record the subject material once and re-use the same video every year, so now we don't need to hire teachers anymore!"
"We are making everything legal so we don't need to hire policemen!".
Why is everything trying to replace programmers?8 -
debug hell
senior: i'm going to read the code changes of the PR that caused this bug, many files , lots of lines of code to see if i can suss out this issue
me: skimmed the PR, i give up, unga bunga time, time to compare the variables in the debugger between the different implementations, found the difference
due credit, the unga bunga approach worked this time, might nto always work3 -
> Opened PR on May 2nd
> No response
> Bumped them on August 3rd
> Closed without response 🎉
> Questioned them, no response yet..6 -
*lunch break at work*
okay, let's play some dota...
*playing dota*
see crush eating, talking, flirting and having fun w/ someone... aaah shit heee weee go again 🤪 or not, whatever, I don't care, yeah, she's not my gf, I'm fine, everything is fine...
*a few minutes later*
client: hey, need this change right now
me: ok 👌
*keyboard sound*
ok, done, let's create a PR
*PR created*
me to myself: yeah, told ya
*PR merged*
me to myself again (I'm a sane person don't worry 😈): that was some badass code you wrote. see? I don't care about crush
*a few minutes later*
client: why the fuck did you ask to merge into master? (I created 33 PRs before and all were merged into the correct branch so they didn't check anymore)
me: *looking at crush 🙄*1 -
Classmate : *Makes trashy PR on my repo to get hacktober PR*
Me : *is disgusted, guides him what to add in the PR to make it better*
Classmate : ok, *closes PR*
<4 Hours later>
Classmate : *new PR, this time worse and wants me to merge*
Me : (╯°□°)╯︵ ┻━┻1 -
Am I the only one the sometimes just makes a PR that won't fix the issue but at least shuts everybody up so I can investigate in peace.3
-
PR used to mean public relations to me few months back. Now it just means pull requests to me.
The fuck happened. Anyone says we need to improve our PR, I'm like how do you improve a pull request and I end up face palming -
How to make me not want to
ever contribute to you:
'Please read and sign this CLA'
( Also telling me that shit only whenI try
opening a PR, WHAT IS WRONG WITH YOU )5 -
next hacktoberfest: prepare CoC and generated PR descriptions, splash vomit it onto everybody who participated and offers high difficulty merge only rewards - PR and get it merged - if they don't merge it, tag some twitter accounts automatically based on hair color and ping some news outlets via twitter and mail. 🙂1
-
Currently listening to my housemate, a tech journalist, talk to a PR person for an ML company, about how great their product is.
I want to vomit.1 -
Alright, it looks like everyone at this bank, a client, I work for will now start avoiding me. I'm usually the only person that takes the time to review PRs and give a feedback. Everyone just seem to click accept because they can't be bothered.
A few months down the line, they begin to wonder why there is so many tech all over the place.
Good luck to anyone that wants me to review their PRs. I pledge to continue to take the time to review PRs and give feedback. I will not be pressured to click the accept button on what I perceive to be sub-optimal code. So help me God.2 -
When your PR has been sitting for days, and your co-worker submits a PR for the same thing and merges it right away.
2 -
That moment of panic when you think you have done nothing all day before you remember that you integrated 2 libraries AND contributed back with a PR of feature enhancements. Today was a good day!
-
Thanks GitLab.
After I get notifications about the final replies to my 6 month quest of updating someones GitLab README, I didn't expect MY fork to have been modified ( and thanks to that, made ugly / they removed all spacing, vertical & horizontal )
Where the fuck even was the option that GitHub offers where it prevents people from just doing whatever to your shit in a PR?
Why the fuck isn't this a permanent setting for either ( lab & hub ) so I don't have to manually turn it off every single time.
I didn't even think about that option up until now, since the maintainers didn't touch anything and everything seemed fine, but now that it was about to be merged, they suddendly got the bright idea of squashing everything into one commit and that on my fork itself, .. really helpful.5 -
That feeling when the code in a massive PR is of very high quality... Only comment is about some class name...1
-
Soooo....,fellow Devranters,some moron just sent a PR with just an added space.....
Idiots never cease to exist8 -
Ah yes, The Hacker News intentionally using intendation errors in python 2 to screw over people using their ddos script. yes. That's gotta be the reason
why the fuck am I even following these trolls
3 -
Yesterday was my 28th birthday and also my first PR was accepted on a open source project! I really wanted to start contributing, awesome day!
-
Writing a feature critical for production in 2 hours of solid focus during the morning.
6 hours later it's still not in the build because:
* tech lead wants the code to move to a partial class instead of an extension method, delaying the UX review. No guidelines for this ever existed.
* after seeing the result, the UX team wants some element to be dynamic. A line. A friggin horizontal line.
* after adding the dynamic shiny frigggggin line, I try to test the feature with the server. It is still not deployed because the server guy went home. "The PR was not merged so I assumed we'll add it tomorrow".
Another day at the meat grinder.6 -
Nobody reviews my PR into test branch
The only guy who reviews it is the new senior dev who isn't yet used to how the company works, leaves comments about useless stuff and doesn't fucking approve
Jesus fucking Christ5 -
That feeling when you're finally done with a pretty big PR and ready to go live. You excitedly send it out to a few of your peers, and then... 20 comments! The real work has just begun 😭1
-
> Make a small PR
- Added missing license text
- Cleaned up the tiny README
> Wait
> @ the author, they don't have
any other way of contacting them
> Wait more, month+
> Denied, no explanation
> Be pissed, head over to devrant12 -
My list of open PRs didn't descrease much since the last Rant, when I went through almost all and updated them.
Still 77 open ones.
On the other hand, my PR for the SteamCMD GUI that I had just finished was taken almost immediately!
https://github.com/DioJoestar/...1 -
24 PR
Giving back little gifts of code for Christmas 🎄
24pullrequests.com
Yayy!! Hoping to have a productive PR-full December✨
2 -
> Contribute to someones project
> Wait half a month for a response
> Ping them
> Have your PR denied without reason
> ??
> 'I reviewed it, and I'm not gonna include it.'
How about you say WHY you didn't?! -
Just review and merge my PR already!!!
Damn is it frustrating to see PRs stagnating after finally finding an open source project I can actually bring something useful to :(4 -
Push a PR that fixes 7 bugs...
Feel like a pro :)
Trying to get the 2 required approvals for my PR on a Friday after lunch...
Feels like pulling teeth :( -
This moment when someone mentions you in an PR of an huge ORM clusterfuck with associative tables and discriminators...
And you accidentially say "Yes I'll look at it later" because you thought it was an tiny PR -.-
Should have opened that link first.7 -
So i’m making my first Angular app here. I commited the first code setup and shot in the PR. I got 40+ comments so i’ve been fixing them all day yesterday.
A part of the comments i don’t understand yet so i ask if the colleage can watch with me and explain ehat how and why.
What does this nitpicker motherfucker do? Add more fucking comments to the PR and totally ignores my requests for explanation. Fucking anti social dick.4 -
We live in the world where “At least I’m not a pedophile” is a genuine PR strategy. If you’re kinda famous, all you have to do is clear the lowest bar imaginable.3
-
when a senior and tech lead write conflicting PR comments ~1 week apart
i dont give a fuck, ill do it either way you want but you 2 need to sort out how the fuck you want it5 -
According to my teammate, punctuation and rules of grammar doesn’t exist. This lady raises a PR and you can’t fucking understand shit.2
-
Till now, hacktoberfest has been really bad more me.
Why so?
I got 4 PRs for my project, out which 3 were identical.
I reviewed them and commented to fix the bugs. The Unit Tests are failing and they don't bother to send out a correct PR. And they don't even bother to fix them and respond. They just want to make 4 PRs to get the free T-Shirt.
Just finish the PR and make it pushed to the mainline.2 -
Do you guys know the feeling when your opening PR on side project late at night..
The CI takes forever to make all the analyses and checks and you almost fall asleep because your so fucking tired? -
Sometimes code is correct but so wrong. Came across this in a kotlin PR today
If (thing != null && thing!!.field != null) {2 -
I never thought big about Whitespaces until Hacktoberfest came by.
Fed up with the amount of PR and notifications I am getting on my repo . Most of the time they create a PR to create a Whitespace and then delete it . Now I have put up a Repository to at least add some joke instead of those Whitespaces11 -
Finally start contributing to the FOSS world. I’ve used stuff like express and vscode for years, but am yet to open an issue or submit a pr to any major FOSS repo1
-
Me reviewing PRs lately:
"Should I fight it now, or should I let the abscess grow?"
——
But in my distress/demotivation it’s usually: peace now, pain later2 -
The colleague who did this cited "Keep it simple, stupid" in another PR.
?????
https://devrant.com/rants/4497101/...3 -
It's a Monday, I've been trying to fix a bug since the morning, I cannot read or write any code. I tried to review a PR, still cannot read the code. Getting frustrated by the slightest problem.2
-
I love open source. Really.
BUT I hate maintainers/owners who do not respond to any kind of message/issue/PR for months.
Also of course they dont tell you how you can setup the dev environment yourself :)5 -
https://devrant.com/rants/1547095/...
You see that ?
It didn't change. At all.
Let's call it an emergency but let's not do it, yeah.1 -
Well, look at that, I fixed the bug and it's the end of my shift. Alright then, let's PR this shit and clock out!
CHECKS FAILED
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAHHHHHHSDJAGSJAGJR -
My colleagues: "We should fail for scalastyle issues! Warnings will get ignored! Nobody fixes them! We should enforce a clean code style!"
Also my colleagues: Create PR with loads of `// scalastyle:off` flags comments.
¯\_(ツ)_/¯1 -
One thing I have truly learned from software development is DON'T REINVENT THE WHEEL. Someone out there may have already implemented such functionalities and if the library is missing something a PR is always welcomed! (Obviously taking about open source libraries)6
-
whenever I ask for PR/MR reviews.
I know I shouldn't. I can't help myself. I present my work, my baby, for their trial.9 -
I wanted to make some changes to one project on GitHub. Forked, changed things ( in new branch), make PR, waited.
My PR got positive feedback, but was closed without merging.
Upon me asking why, I was banned from all their repos.
Inclusivity anyone?1 -
How do you clean up branches while working with PR ?!
It’s a nightmare. For each “bug” or feture there is a pull request created. As far as I know you MUST create a branch.
It’s easy to clean up GitHub (I’m just deleting branch after accepting PR. Which actually doesn’t even delete it for X days or something).
But local branches. OMG. It takes me at least 10 min/week to clean up and some of our devs don’t bother. They literally have 50+ local branches.
How do you manage that ?
I’m just about to write a script which deletes every local branch except selected (Yep UI with list of branches). But seems like overkill.5 -
In my PR :
Senior dev A : "You should change the format according to <link to coding standard>"
Me : "But it doesn't mention anywhere about that format. <senior dev who wrote the standard> also agrees with me. Other reviewers also already approved."
Senior dev A : **proceed to give me an example from a file that's not even in the PR scope**
Me : "I cannot find that file in my PR"
Senior dev A : **give me another example example from my PR**
Me : "Okay I missed that, I am gonna fix it, but other files are already using consistent format. I have already merged changes for 500 files using this format, and I still have 400 files to go.
Do you really want me to revert the changes from 500 files?" :/
Senior dev A : "I don't want to be your enemy, I just want to make our codebase better"
Me : **Mad because he took this personally.**
**I don't want to be your enemy either. I also care about the codebase. I just want to finish this ticket ASAP instead of implementing your cosmetic changes that's not even in the standard so that I can work on another ticket that will have more impact to the company**
Senior dev A : "Ok, I will approve it, just add some whitespaces"
Me : 🤦♀️
I sometimes think that some senior dev just want to flex when they're reviewing PR.
They just want to let people know they wield the power.9 -
Out out new guide lines for pull requests.
Reviewing around 10 PR today. All respect them
Overload is pleased. ;O1 -
Oh you have a pull request that fixes a bug impacting customers atm? This is a perfect opportunity to write a novel that debates optimal coding practices in the review
Smiling eye twitch2 -
/me doing the 23rd revision of a PR because my colleague reviewing it comments on every imaginable way his opinion of code standards differ from mine:
git commit -m "." -
Oh my fucking god, we're doing SCRUM, why does every task get stuck in review limbo and take a sprint and a half minimum because of it.
-
Anyone ever thought that opening a PR for a feature you requested in a repository is actually giving life to the phrase, "Be the change you want to see".1
-
when people attribute you as the author of bad code you didn't write, as you receive PR feedback to update it
when you are updating something different in the same area3 -
Someone raised a PR for the opensource project "fast XML parser". Since this was a major change, it was difficult to review. I asked for the purpose and requested to break it into multiple PRs, where 1 PR should have related changes only. And any good change but unnecessary change can be avoided to scheduled for later.
We had long arguments for a month or two.
I don't know why but instead of breaking the PR, the contributor keep updating his PR for every commit someone made on the original repo.
He also stopped contributing for other changes, and commenting on other issues. (Change in the behavior)
Finally after 5-6 months, I had to close the PR as it was not active, having conflicts and not as per guidelines. -
Question: I completed a feature on separate branch. Since I'm not allowed to merge things on the master branch (only pm is allowed to) I open a pull request.
However, PM has decided that he will only accept PRs which can be automatically rebased & merged.
So now i opened my PR and PM says that GitHub complains that the branches cannot be automatically merged.
So I rebase the branch - push and tell him to try again. But the same issue - GitHub won't merge the PR. So I try again - rebase the feature branch onto master which runs me through the same rebase steps as on the last try. I successfully complete this one too and push. But still - GitHub won't swallow the PR.
Anybody an idea what could've went wrong here?6 -
Sending approximatively a 100 PRs to trigger a reaction of my colleague.. Like "it would be great don't you think so..?"
I didn't get one (PR) back... -
Currently having a stupid fight in my PR comments to remove dead code because I refuse to write a whole book to justify a cleanup commit.
-
Todays "WTF Bitbucket?"
You can mark a PR with "Requesting changes" even if it was already merged but you haven't refreshed your page.
The whole PR page is loaded with a dozen independent requests but you cannot reload a single "widget" (e.g. Activity) without refreshing the page.
And then you do an API request "mark PR with request for changes" and the server accepts that, even if the PR is merged. Why? Nobody looks at a merged PR with Requested changes. You would expect a warning "cannot mark request changes, PR already merged" but no, Atlassian fucked up here again.
The new "PR experience" is shit. Just loading everything in a separate request does help nothing if I still have to reload the page to get an updated PR view.4 -
At the Pycon Brasil in a sprint to help Russel Keith-Magee project, the PyBee and got the first accepted PR! The prize was this challenge coin! Everyone is welcome to join, check the project on https://github.com/pybee/
1 -
Today started good, the latest PR merged in took our Flutter app to 66% coverage with 1009 tests.
This means we also have 1001 more tests than our companies other apps combined. 🤣 -
I don't get why this retard keeps ignoring my comments on a PR he asked me to review. He is a level above me so I can't push it. I just approve his PR and let him know I do so but with a comment. He then ignores the comments and merges his rubbish changes into the codebase thereby creating a tech debt.6
-
@netikras I had an idea for @chatgpt. Went something like this. What do you think, should I PR it into the bot? (in bash ofc)
13 -
What's that? You committed the tmp/dist/cache field for something only YOU run locally and asked me to review it. Just GET OUT.1
-
> Start a new project
> Search for modules / libraries you will need
> Find something promising
> See that it's not well maintained
> I'm just gonna send a quick PR
> Proceed to rewrite most of it.
> Huh ..
> Repeat~1 -
When you decline a PR because you KNOW the code isn't going to work, and spend 40 minutes proving what can be inspected in 5 while the creator chats up a storm..2
-
I shall delay your PR with my giant egotistical scrotum by:
- Use less words for your function name
- Use this obscure pattern you have not learnt in your outdated compsci degree
- Each loop should get their own function
- Your function has too many parameters
- You must name every instance of magic numbers / strings
- Here, have another obscure test case to write9 -
I got my very first PR to a repo of mine. Naturally, I got out of bed at 4am to test and publish it.3
-
Spent yesterday working on a card for adjusting a Graph query to properly sort records. Made all the specs. Tests them all. It gets approved.
Rebased today, and the project lead (who made the card I worked on, told me to work on it and approved my PR) put in a sorting scope that's totally different, in order to "unblock" a frontend dev.
After examining it and discussing it, my work was totally unnecessary, and didn't do what we really needed anyway. Closed my PR. Don't feel like doing shit today.2 -
So, apparently the female front-enders won't get fired even though they submit works that even doesn't meet up close to the requirements.
Management want to keep good PR.
Fuck GirlsCanCodeBullShit.16 -
The hardest part in my job these days is thinking commit and PR messages :/
I believe my code and commits and PRs are always self explanatory, the company doesn't agree apparently.2 -
Don’t commit your terraform state to github please, especially if it contains over 20 API keys for various services, and database master passwords.
Not speaking from experience of having to do some frantic rebasing of someones PR *eye twitch*6 -
Ever look at someone’s PR in your project repo, remember that you dislike that person because they think they know it all, give it a few seconds, and say fuck it and completely ignore the fact that they submitted that PR?
THEY WOULD OF THOUGHT.4 -
Who else here smokes weed through the day (WFH) when the work for the day isn’t that cognitively demanding? Like updating config files, raising a PR, or doing some silly RnD etc.7
-
My best review was when i changed the code that someone suggested in another PR, which was highly critiqued by the OG devs. One pull to the latest commit and PR to his fork later, the OG dev comments "that looks good" and merges it.
Celebrated for sure that night. I've been hooked on contributions to open source ever since.2 -
Everyone has project builds. Boss comes in and says we need to build 12 landing pages on 12 new domains by end of day. Repurposes PR for content, my designer, and 3 devs.
Happy goddamn Friday.1 -
When you spend hours in a messy codebase to fix a bug properly and add an integration spec to cover that specific case.
And even you do a round of testing on staging + providing screenshots, there is always someone on the team that will write in your PR, "It works, I tested the change on my machine".
I understand that some people are skeptical but to the point of not trusting integration tests + screeshots/recordings then please test it on staging or production next time because if it works on your machine doesn't mean it will work there ;)2 -
PR (tested)
-- if(a){ x(); }
++ if(a && b(x)){ x(); )
Reviewer: what if a'?
Me-think: but da'/dx not defined, :'(4 -
I just want to give a quick shout-out to the advertisers who were so quick to monetize a pandemic and pull on the heart strings for some PR value.
Well done, lads.2 -
QA people hurt my head. "I found this issue" cool write it up. Proceeds to not write it up. "Hey this isn't working" yeah your on the wrong PR. For the 80th time. "Hey I just found out 4 days after deploying this key feature is no longer working" did . . . did you test it? I'm irritated. Probably because all of my tickets got sent to triage because I pushed them to the wrong PR. My life hurts. The burn out is real.
-
I don't understand people that say
'I like the current format of the readme more'
...
What formatting??
This was the PR:
https://github.com/SakuraNoKisetsu/...
9 -
*click 'create pull request'*
*satisfied*
*pat on shoulder*
Will get comments surely, but I'm happy that I could make a PR -
I created an application A which was faster than B. As the authors of B created a repo for benchmarking and mentioned
'Do you know other Bs? PR! :D'
I created a PR in Apr.
it is not accepted yet.4 -
Was testing someone's PR but the change did not get loaded into the program. After 2 hours I realized that there was a comma too much in a JSON file.
Fuck this shit, and fuck this comma in particular -
The owner of a github repo has added me as a contributor but haven't given me write access, so i can't push commits.
When i asked him, he said i have to make PR. The fork button is also disabled. So i guess i can't make a PR also.
Now WTF i am suppossed to do now?
No write access, fork disabled . Still i have to push my commits ....ughhhh2 -
write simple working code with some duplicated code (less than 10 lines) and have compile time safety , NAH
write more complicated code you have to spend time fixing thanks to PR feedback -
Why is it so common for people to insist on following particular patterns at PR when they have no concept of why the pattern originated or when and why it should apply?9
-
`if (boolean)`
Would you tell a colleague that their PR needed to be refactored because they used parenthesis around an if block that didn't need it? I'm all about explicit order of operations and often add brackets and parentheses around things that don't need them. It's cool if you don't want to put them in, but does the PR need to be held up over this?1 -
Me: You didn't squash that PR into develop....
Them: There was no option to squash...
AAAAAAAAAAAAAAAAAAAAAA 🙂7 -
I made it as dev when the repository owner increases stale time for pull requests to wait just a bit longer for my change
-
Nothing says asshole like a guy who won't approve your MR even though the feature is working but they prefer implementing it using their preferred approach.
Different coding styles for different folks. What matters is that the approach used is efficient, working and tested. But oh no, you have to write the code exactly how they want it.
Good thing we're free to merge our own MR when the reviewer takes more than two days to merge it.4 -
When you are reviewing a PR in which the author has used utilities/libraries that were written by you(which were very generalized and DRY but required for you to read the docs to clearly understand their usage). But instead of using it properly they modify it for their specific usage and made a freaking PR.
I just can't wait to finish the review and slap their face with a printed copy of the FUCKING docs.
Seriously, read the goddamn docs. And, if you do change the lib, please update the doc too. -
Today i wake up and i expect some bit of sanity in my job. Our CTO Respects no processes and stuff. I check PR's that are requested for review.
PR i 391 files long and it's not node_modules commited :|1 -
"We don't have time for refactoring this PR now, please open a new task and we'll work on it asap."
Merge, Deploy, and set new task as Won'tFix two hours later :-/ -
I was an intern in a company. They invited me for a meeting where they discussed whether to clone-edit-push or fork-edit-pr.
-
So I’m pretty sure I’m wrong here but I wanna rant anyways:
Had a US to pick up a date or time based on a zone and use that in the db in all locations, US had four functions written and told that only these need updating and DB itself will have no updates. Update four functions and made PR. Tech person who filled in US saw PR and approved, I merged and gave to QA. QA asked why some things aren’t being updated and I said oh those are meant to be updated too and I said ok. Get a defect. Checked that there is way more functions to update than needed, and tried so that no dB update happens in US. Made PR, reviewed and pushed. Still something is still not updating (this time purely mb I guess) another defect. I make PR again and dude asks why I don’t change it in this way which requires a DB change. Resist the urge to tell him he specified in his US no dB change. Did the thing and now it’s still in process. Product owner is pissed with amount of defects from me. -
pr();
I use this in all my project now...
It was the first time I've felt really daft that I'd been hand coding:
<pre>
<?php print_r($array); ?>
</pre>
Needless to say I now have a big collection of beautiful little functions! -
(after morning coffee) Today I’ll change the world and write the most elegant and revolutionary piece of code ever.
(end of day, after 8 zoom meetings and 5 gdocs comment rounds) guess i’ll do these 2 PR reviews tomorrow.1 -
Ugh. Been working on a huge React component that's now dependant on another co-workers PR, and had this one open for like a week. Go to merge and one of the fucking useless reviewers decides that *now* is the best time to flag everything wrong with my code!
I get it, it's good feedback, but uh... Could you not have done this a FUCKING WEEK AGO instead of RIGHT BEFORE I GO TO MERGE?!
Prick.2 -
Well here i thought i would have done work...and pooof its time to go home
All i did was refactor with and make PR...
*SIGH*
I guess today was one of those days where little work was done -
If some older employee writes the same code, nobody bats an eye. If a newer employee (with less than 2 years in the company) writes the exact same line, everybody loses their minds (in PR review)...
Not that I give too many fucks generally, but sometimes this partiality is annoying AF.
This causes: https://devrant.com/rants/2263742/...1 -
I had a branch <refactor> where I changed the structure of some folders (and did appropriate changes in imports) for organization of the feature I'm developing; I then merged <refactor> into <feature> and created a PR from <feature> into develop. I let the PR be known in Slack.
Yet nobody reviewed the PR.
Whatever. I created <new-feature> from <feature> locally, and started working on it. Then I merged <new-feature> into <feature>, and pushed it into its remote counterpart... well, only now have I realized I haven't merged the remote <feature> into develop. Now I have a PR in which the documentation doesn't tell all the changes anymore. Because nobody reviewed it before and I couldn't merge it. Now instead of keeping on working I gotta come here to vent my frustration before I can do anything.1 -
When all the discussion about a PR took place somewhere else so anyone looking at GitHub thinks they just blatantly disregarded GH etiquette
-
When you change three lines in a PR with 100 changes that breaks the whole functionality, and it starts working flawlessly 😕 seems like testing PR before merge could have solved the doomsday
-
Has anyone had success with GitFlow hotfixes and GitHub branch protection rules? Finishing a hotfix requires pushing directly to develop, but GitHub prevents it if PR policies are set up :/8
-
People complaining about people pushing to master branch directly: can't you actually protect master from force pushes and have each PR reviewed? Why is that so difficult to understand?3
-
create large PR and annotate points of interest on the PR
still get told to walk through it for people as they won't be arsed to read it, or even look at the points of interests themselves1 -
When you are tearing you hair out trying to figure out why the PR you're reviewing isn't working. Then you realize you forgot to pull the latest changes!
-
They should merge my pr first, so the one who will resolve the conflict is not me. I spent 3 days and nights cleaning 60 files in the projects. 60 files! Sadly, my manager merged other pr with 2 files changes from my junior first, destroying many of my changes.5
-
Full code base with 0 comments. Either it's utter genius or terribly poor.
And I'm sitting here reviewing a PR.4 -
This was my first week as Jr Dev. I'm excited, first commits, PR, issues and hotfixes. Any advice for me?
Have a nice weekend!! -
The smaller the code changes the longer the name of PR for the code.
And even more review changes mentioned by the reviewer... -
Why is the bitbucket PR "experience" so god damn slow and sluggish? Every shit and their mom is loaded from a different endpoint but to get the updated list of PR approvers, I have to reload the page.
The fuck why?3 -
Got pissed that my story delayed the whole project by 3 weeks (major story, lots of changes, and management decided to put me in a few extra activities outside of the project).
Stayed up until like 23:00 to deliver PR.1 -
Question for devs:
How are y’all handling copy changes in your app? What’s ur process? Do you put up a PR for every small copy change or do you use a special tool or something?4 -
I was supposed to just review the PR. But I couldn't stop myself from making minor changes.
It has been 4 hours now. I'm thinking if I should raise a PR for the PR.6 -
I just commented a test so the PR passes and the feature reaches next release; I can't fix it (Damn react testing library tests)
but after that, the linter failed for the same PR, so I just fixed it and did a git push -f
I guess once you cross the line you cannot come back
feel my pain1 -
When you need that one feature from a framework, that it just not have. So you have to use a custom version till your PR has been accepted.
I see a possible problematic future... -
I've had an idea for a possible PR. Filtering out certain categories. I don't really want to see any joke/meme rants anymore, and filtering out other types may be helpful.2
-
How does your organisation and team balance PR comments demanding changes and dev time?
Here, while fixing PR comments we sometimes end up wasting as much time as we took in actually developing the feature... As a result, almost every major user story overshoots the estimation and almost every sprint gets delayed.
Yes, to each his own; but talking in general, why do you think this time wasting happens?
Do you think that happens because some of us are not as experienced as the others, the existing code not being up to the mark giving a bad example, or just a skewed review process?2 -
Pull >>>> Rebase
The advantages of rebase (clean git history) are minimal but the risks are massive (rebasing in the wrong direction, rebasing after raising a PR, rebasing a public branch)4 -
Just reviewed one of the team members' PR and asked her to follow Semantic HTML, she said I'd rather not to, because I don't like to discriminate between tags! Honestly?
-
I have been working in the same PR for 2 months. Many metamorphosis of it i would say 😂 I even made it all the way to prod and had to be reverted coz it was causing straight chaos. I have worked on some pretty complex features in the past year, this the smallest yet most complicated ask i have ever received. Orleans really put my patience to test and here i am, right now completely unable to write any code. I am just here planning my vacation in 4 weeks time.1
Top Tags
Weekly Rant
View