Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple APILearn More
Search - "pr"
Manager: What’s taking so long on that PR?? It’s just some small styling adjustments
Dev: No it’s not you added an entire new calendar module that doesn’t work
Manager: Ok but besides that it’s just a small couple of css edits
Dev: You made styling changes in 50 files, half of which break our mobile responsiveness
Manager: Well then STOP talking to me and FIX IT if you’re so smart.
Dev: You also added a series of filters on a table in this same PR that cause th—
Manager: OK SO I GOT A BIT DISTRACTED THE FACT IS IT ALL NEEDS TO GET DONE SO IT DOESN’T MATTER IF IT’S ALL ON ONE PR SPLITTING THINGS UP INTO SMALL UPDATES IS JUST UNNECESSARY BUREAUCRACY AND IF YOU LIKE THAT THEN GO. WORK. FOR. THE GOVERNMENT!!!
Manager: Hey Dev I need to do QA on this PR.
Dev: That PR is not finished yet
Manager: Well do QA now anyway, that way when it is finished it can be merged in right away since QA has already been done on it. It’s a project management technique called “fast-tracking” and it improves efficiency.
> make a change
> PR gets rejected
> IHATEFORALIVING! YOUR CHANGE IS NOT WORKING! EVERYTHING BREAKS!
> 3 hours long debugging session
> We find out a whole bunch of bugs
> Suddenly, everything works
> None of the bugs had ANYTHING to do with my change. In the instances where the app broke, my code wasn't even being called at all.
> My change was literally the one and only working thing
I wish life was like in The Office, when you just stop what you're doing and you drop the Jim stare at some camera3
First I wanna say how grateful I am that devRant exists, because my friends either don’t understand this vocab or don’t care lol.
Last week I worked on a pretty large ticket, opened a PR with 54 file changes. Just to follow standards I set the PR milestone to a future release version, but the truth is I didn’t care which version this work ended up in— I just needed it to go into the develop branch asap.
Since it was a large PR there was some expected discussion that prolonged its merging, but in the meantime I started a second branch that depended on some of the work from this branch. I set the new branch’s upstream to develop, fully expecting my PR to merge into develop, since that’s what I set the PR base to.
I completed all the work I could in the new branch, and got two colleagues to approve the initial PR so it would be merged into develop, I could add the finishing touch and get this work done seamlessly before the week was over. They approved, it got merged, I pulled develop, and… my work wasn’t there. I went to look at my PR and someone had changed the base branch to a release branch. It was my boss, who thought he was helping. (Our bosses don’t actually work on the same team as us, so he didn’t know. it’s weird. We have leads that keep track of our work instead.)
I messaged him and told him I really needed this in develop, knowing our release branch won’t be in develop for probably another week. I was very annoyed but didn’t wanna make him feel too bad so I said I’d just merge the release branch into my new branch. So many conflicts I couldn’t see straight. His response was “yeah and you’ll probably have a bunch of package manager conflicts too because that’s in that release.” He was right— I have so many package manager conflicts that I can’t even see how many compiler conflicts there are. I considered cherry picking my changes, but the whole reason I set develop as my upstream was to avoid having any conflicts since I’m working in the same functions, and this would create more.
So I could spend the next (?) days making educated guesses on possibly a thousand conflict resolutions, or I can revert my release branch merge and quietly step back and wait for the release branch to be merged into develop.
I’m sure cherry picking is the best option here but I’m genuinely too annoyed lol, and fortunately my team does not care to notice if I step back and work on something else to kill time until it’s fixed automatically. But I’m still in dire need of a rant because my entire plan was ruined by a well-meaning person who messed with my PR without asking, so here is that rant and I thank you for your time.8
Seriously, a new guy joined out team and suddenly I'm out of my comfort zone and started following the pattern I used to follow. The thing he did, commented on my PR, a lot of comments.
I had this thing that hey now I can control anything right, new guy? less experienced? yes, so I don't need to be intimidated. But I realised today that I'm easily intimidated my intelligent people because I think now I am the inferior one.
I will push myself to think about it in a better way, by looking at it positively, to learn something from it.10
Manager’s PR Description: I made changes relating to a ticket which should work as expected. I also made various other changes as I saw fit, test whatever else I changed too.
So, my wife got this new PR job where she sometimes gets called in the middle of the fucking night because some jackoff in Singapore said or did some shit.
Since "husbands that work deep into the night get cheated on by their wives", and I believe in equal gender rights, I thought it would be a good opportunity to watch the new episode of the series we watch together. By my fucking self.
Is that how it feels to cheat on someone?1
So today my pr needed approval. One of the lines of code created a unique ID using the uuid4 functionality.
I got a reject saying I didn't handle a case where I would get the same uuid twice.
Well, I guess it would be the problem of the developer working on my code in a couple thousands of years 🤷♂️2
Started a new job last week. Pays a tad below average for position, but i get training time and budget for anything i want.
So far i have had few days of company introduction, and now a week for training courses related to position.
I have not seen any code yet, brought no value in, just joined.
Massive green flag to me.
Alright, it looks like everyone at this bank, a client, I work for will now start avoiding me. I'm usually the only person that takes the time to review PRs and give a feedback. Everyone just seem to click accept because they can't be bothered.
A few months down the line, they begin to wonder why there is so many tech all over the place.
Good luck to anyone that wants me to review their PRs. I pledge to continue to take the time to review PRs and give feedback. I will not be pressured to click the accept button on what I perceive to be sub-optimal code. So help me God.2
Am I the only one the sometimes just makes a PR that won't fix the issue but at least shuts everybody up so I can investigate in peace.3
People should have mandatory lessons in vector processing.
In canteen, after lunch, there were 4 places you could place your trays. But only small, one-way corridor, for one person at a time to get there.
Every person picked the first place and while they were placing the tray, people behind them had to wait. Huge line started to form. If they, instead, always picked the last empty place, all tray places would be occupied for longer and the processing speed could increase almost 4 times.
Textbook vector processing example.2
senior: i'm going to read the code changes of the PR that caused this bug, many files , lots of lines of code to see if i can suss out this issue
me: skimmed the PR, i give up, unga bunga time, time to compare the variables in the debugger between the different implementations, found the difference
due credit, the unga bunga approach worked this time, might nto always work3
Currently listening to my housemate, a tech journalist, talk to a PR person for an ML company, about how great their product is.
I want to vomit.1
what is the point of having massive HR departments if something as expected and frequent as university hiring can't go smoothly?
i managed to reach the interview round for a big 4 firm only for the interviewer to not show up for 4 hours from my time slot (i waited the entire time - took periodic screenshots for proof), HR to say "we'll reschedule your interview, this happened because of internal miscommunication" more than THREE months ago, and dip. until december they'd repeat the same. now they've ghosted. thanks, virtual hiring.
how is it the candidate's fault? found out this isn't rare by speaking to a few others from my network who i knew were interviewing for the same firm. for students whose lives can change completely based on the outcome of an opportunity that they came across due to sheer luck and could definitely make use of because of their hard work - this is so heartbreaking and demotivating.1
I love when devs bitch about the size of PRs on a very standard sized one. They're all related changes that can't be broken up. Do you want the app to be broken between PRs? He spent more time bitching about the size of the diff and telling me how he does it better instead of just reviewing the code. A tip or an ask is one thing, this was a wall of text.
Oh and he still didn't approve the PR, which I know he looked at, and didn't leave any blocking comments.5
can't believe it but things actually have started to fall into place on their own, career-wise. feels unreal. need to work enough to afford a cottage with a cobblestone path & my life will be complete2
Not leaning on unit tests. I usually write them after testing my code manually, and lose time for testing feature by hand.1
Stick to one project about which you want to learn but don't know how to do it,complete it...and now you have learnt something new
Why comment on the same thing during code review??
I submitted a PR and had to make a design choice that propagated throughout the module i was working on.
During code review, my coworker commented on every...single...line that this change effected asking "why are we doing x here?" instead of just creating ONE SINGLE THREAD with this question for discussion. There were at least 10 review comments on github from their one review that said "why X?"
Is this normal? Ive only had a few programming jobs and this is the first time this has happened to me.
personally, when someone makes a choice like that, i just make a comment and save the rest of the review until that is addressed.6
Oh my fucking god, we're doing SCRUM, why does every task get stuck in review limbo and take a sprint and a half minimum because of it.
There has to be a software project bingo somewhere where I could just mark one item at a time of what's wrong and should be fixed, eventually leading to the same loop all over again. Items include, but are not limited to:
- The application is too tightly coupled
- There are too many repos and people can't keep track
- Someone forgot to create a naming convention for everything
- Nobody is reviewing pull requests
- Someone opened a PR for their 1 month of work
- Some team created a service for themselves, that doesn't cover use cases for every other team (who didn't tell anyone they needed it), thus it was a bad thing
- Business owners telling something needs to get done now and go talk directly to a developer
- Nobody thought about network latency in microservice architecture
- There's an invalid translation in this string, let's push the MVP another two months to make sure everything is perfect before launch
- The API gateway has business logic in it
- Business wants to focus on output, development teams in outcome
- "You need to request a virtual machines from the IT department so we know you won't mine bitcoin there!" Takes two months to fulfill that request.
- <add documentation here>
- 675 vulnerabilities in packages
- People complain about not knowing what others are doing, but nobody wants to speak up1
I wanted to make some changes to one project on GitHub. Forked, changed things ( in new branch), make PR, waited.
My PR got positive feedback, but was closed without merging.
Upon me asking why, I was banned from all their repos.
senior: i don't know css well (which is fine as i don't either), but i want you to do this differently and their suggestion doesn't work, so go figure it out
that working stuff we have on the PR? nah
when people attribute you as the author of bad code you didn't write, as you receive PR feedback to update it
when you are updating something different in the same area3
every day my boss says he'll review the requirements for our product. every day he forgets to do so. every day he asks where the update for the next stage is. every day i remind him. every day he forg ---2
Few things hack me off more than devs who can't be bothered to do a task properly, so just submit some random crap as a PR that looks half correct at some surface level in the vague hope it gets approved.
This team is about creating decent, tested, reliable, resilient backend infrastructure, and we need to trust devs in order to do that. If you want to pull the half-arsed, do as little as possible and get paid as much as possible approach then sod off to higher management somewhere.1
My TL has his custom rules to format code, we use python and black as formatter, still, We have to remember his rules. He forced us to mention type rather than compiler do it for us. Our pr will not be approved until we do this.
My point is if you want to follow this then forced it programmatic way, event better use a language which gives this all by default. why we should remember all of these rules. Other team members are also doing the same and I hate those pr comments like there should be two empty lines or the type is missing. He never listens to any of us and takes it on his ego.3
Working with new guy who is "senior" is such a pain. We had a factory file that is used to populate tables in endpoint tests. The new guy decided to add a static util method called createTestRecord() to a query builder model. Fucking query builder calls in a static method in a query builder class. I send him messages expressing concerns regarding his approach but never got anything back. The guy just ignored me and asked me to review his pr.
I am leaving in 4 months. Release me from my misery. Fuck my life5
when a senior likes to kick up a fuss on PR reviews, you'll do whatever dumbass shit they want in most cases, assuming it works
but its a relief when a tech lead or architect tells them to fuck off
So I was browsing the https://travis-ci.com website and was bothered by the weird gradiants, familiar layout and awkwardly timed animations (normally I only use https://app.travis-ci.com).
I navigated to all their top-level pages and paid attention to the incoherent/ sluggish design (see screenshot). So I got this feeling that it was a cheap-ass Wordpress template purchased from Themeforest and implemented by a webmaster with little to no dev-skills.
Sure enough, I checked the Wappalyzer extension and it is using Wordpress. Compare that to the old https://travis-ci.org which was custom-built on Ember and looks professional.
I'm aware of the negative PR they have generated over the past year but gave them the benefit of doubt and they have been good in their support and credit allotments, but man... that WP site looks so amateurish and marketed to the wrong target group. I don't know maybe I'll be forced to reconsider4
hey devs, hope you all are doing good..
I was frustated by my salary.. I mean in this job I am good but I didn't got the expected growth..
So I find a job .. but before resigning because I know my boss is cool atleast he will listen .. so I leave him a message that I wanted to do more.. and got the other offers.. He said no worries.. we will match your package.. but now you can be associate TL and handle the team also..
I took the offer..
atleast I am satisified. The thing is new team is mostly are dumbo :( Will see how long I can pull..
or I am hoping my next rants will be something like.. I will join as junior dev pr same salary.. just take me out from this fucking TL role.. because I know what team is going to do.. someone stuck.. ask TL.. someone have internet issue ask TL.. don;t know css.. ask TL.. dont know logic.. ask TL. its look like I have to be google for team
Anyways will see how it goes.. I wish me luck
Ohh yeah if you are in TL roles.. could you share your experience please2
Started working st 8AM and whoops it's 1PM. Then I read the review of a yesterday's PR and just fuck it, I'm not dealing with this today. I'm done for the day. Exhausted beyond belief.2
what are personal projects if not the daughters of hackathon solutions that never saw the light of day6
I spent ~12h working on a simple issue/bug.
7h was spent on rebuilding local dev environment which is a clusterfuck of maven profiles, tomcat, some autogenerated degeneracy, and 2 different build systems for JS.
5h spent on actual bug fixing, code reviews and so on.
create large PR and annotate points of interest on the PR
still get told to walk through it for people as they won't be arsed to read it, or even look at the points of interests themselves1
I am currently going to start data structures and algorithms in python...
suggest me a roadmap according to your experience2
Ugh, no.. You got yourself from dirty dental-dams of “Jif” believers, all the way to passed bass-ackwards. That PR is raw sewage and your demoted back to entry-level if not intern. Oh and while you’re crying with Morty’s dad; consider a career change. Most importantly, just forget WAN ever existed and go back to your parents first PAN device to play solitaire.
All engineers, reviewers and testers who clean up your leaking dirty diarrhea lines.5
I don't know game development but idk I accepted an offer for game development competition..
the fuck I didn't even knew how to make one...
Now I. am working with Ursina Engine....
even the code on google does not work........1
I caught up a scammer last night he was doing some astrology and stuff.
He asked for money......
I gave him a grabify link.....
He gave me his location(accidentally)and told me to teach him the trick....
He wasn't even scared
need more experience for good entry-level jobs, need a good entry-level job for more experience. yay4
Get to know the new company better (Changed job shortly before Christmas).
Learn some DPs, DDD, k8s, finish introduction to hacking course, start doing htb and thm machines, finish and defend my thesis, finish books clean code, thinking in java (reading it to fill in gaps on knowledge), a few books about pentesting.
Among non tech goals: pass drivers license exam for cars, another one for motorcycles, go back to learning russian.
I was supposed to just review the PR. But I couldn't stop myself from making minor changes.
It has been 4 hours now. I'm thinking if I should raise a PR for the PR.6
which is the best cloud provider for a complete beginner (user/dev) in terms of community support, employer preference and user-friendliness?
i know that understanding the tech and concepts behind it matters more than getting familiarized with a specific platform, but i'm looking to build a more diverse profile and have noticed many positions asking for AWS/Azure experience.
since i'll be starting from scratch, any provider with easy-to-follow documentation, online help and certifications that don't leave you broke (would have to pay myself, earn very less as a student from a third-world country, parents/current employer can't support) would work.9
Isn't the subscribe function devrant work like creepy stalking someone...
Like what he commented,liked or posted....2
Does anyone else also feels like "I knew it why I didn't try this way, this was easy" after using stackoverflow1
Hola community!! Everyone going over this, please read this once and honestly answer my query.
I am on a probation at a startup. When i will be full-time, then the startup has promised me to provide CTC of 7,50,000(inr) i.e 10,000$ (usd).
Now I want to switch this startup company. Here are my reasons -
1. Less people, more work. - Well, that's what we call a startup. The tech team consists of 3-4 members only and we ourselves have to do the whole thing from end to end. This consists of designing the architecture, PR reviews, qa testing and coding ofcourse.
2. I see myself that I am capable enough to earn 1.5 times more than the above CTC. Also, all my friends are earning 2x the above ctc.
3. Also, there is no senior in the team except founder himself. This really seems awful as can't learn from anybody.
4. Also, i have plans of higher studying due to which i have to entrance exams. So i need to prepare them too. Switching to an established company can mean more money and less work.
Now, can anyone suggest me whether my reasons to switch are legit or vague??1
Update of previous post
I just got assigned to a project.
Project-specific training is designed to take up to 20 days.
I got materials, videos, and a person who is in this project for a long time to supervise training and introduce me to the project.
Only problem is that the project apparently uses 5 years old version of base framework.