15
Litbelb
4y

I just received my first pull request today.

It wasn't what I wanted, expected, or hoped for.

It was a full-on codebase rewrite.

Comments
  • 1
    Reject and ask for smaller parte
  • 13
    Was it a rewrite or did their linter get abusive and convert all the tabs to spaces across the entire project?

    I've been there before 😅
  • 2
    @C0D4 yup, possible, cause I was once such a guy, neurotic about a perfect shellcheck validation.
  • 0
    @C0D4 I've done that myself several times. This is a C# project though.
Add Comment