2

Ugh. Been working on a huge React component that's now dependant on another co-workers PR, and had this one open for like a week. Go to merge and one of the fucking useless reviewers decides that *now* is the best time to flag everything wrong with my code!

I get it, it's good feedback, but uh... Could you not have done this a FUCKING WEEK AGO instead of RIGHT BEFORE I GO TO MERGE?!

Prick.

Comments
  • 2
    Well, instead of him being a prick, its maybe your responsibility to take care of your PR.
    Why should people be on the lookout for everything thats happening around them. If its your intention to merge it quickly its your responsibility to demand a review, after all its for your code quality, not everyone enjoys reading others code. Why did you want to merge it in the first place without all reviewers accepting and you announcing to merge it so your colleagues can say: „Wait, I forgot to review it.“
    Sounds more like an organizational and communication problem you have there.
  • 1
    While I second @Crismon 's comment, I know the situation (and it's probably due to bad organization and PR's getting too large or even depending on one another).

    Worst aspect of this kind of review situation in my case used to be the reviewer pointing out things to change or refactor that I did not even write by myself, mostly code that had been there for months and only got a different indentation due to a new condition somewhere else in the code, making the reviewer believe it was originally coded by me ...
Add Comment