Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
If there are unit-tests that look fine and the build succeeds then I'm usually OK
-
Testing is not a part of code review. If you see something that you think should be tested, you maybe could test it yourself. But even then, it's better to ask the author to make sure it's tested.
-
@electrineer agreed, if I find something fishy that the author doesn't see I'll test it out to be sure
-
None of you sometimes pull the branch locally to check yourself if it is a potentially really impactful feature that is hard to unit test? (E.g. caching mechanisms)
-
formatc1233yCode reviews tend to vary wildly depending on how busy the reviewer is and other factors, usually they nitpick small details and rarely ever do people spend time understanding a large commit and testing it. I'd argue that QA should be performing testing.
-
kyokid4083y@webketje I always pull the branch locally as a final step of the code review process, but I am sure not everybody does that. This should be developer common sense!
-
@formatc I demand they keep PRs small so that it's more readable and understandable
Related Rants
How thoroughly do you test when doing a code-review?
question
code-review
test