We lost a frontend developer who used dozens of hipster libraries without any communications with other devs and replaced him with this one that has just pushed all the node_modules to master branch with all of her local config files. God. Fucking. Dammit.

Also apparently we have multiple CSS files with >10000 lines now. I give up man G fucking G we lost.

@kudamalam wow, that's some shit luck! Sorry man

Tell him/her about gitignore...

Lol, feel for you dude. Good luck!

Who approved that pull request? Accidentally pushing a local config file or node_module folder has happened to the best of us, but that should totally be caught by a PR. Especially when reviewing a new person's code where I know I am typically extra-methodical

@NotABugAFeature you are absolutely correct, we should have a reviewer and using pull requests. Existing devs just kinda trust each other with direct access to anything in the repo because we are a very very small team.

@kudamalam I'd be careful with that. Even with a small team where you trust one another and know what everyone is doing, mistakes happen. Typos occur, null checks are missed, etc. Even if you review your own code, it forces you to double check every line and to make sure you didn't push too much.

at the very least I'd say for new developers, there is a 3 month probation where you need to go through a pull request. It's extra work but it will save you from the headaches you are dealing with now.