Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
Have you tried intentionally adding a bad PR?
(If you really need to make people feel bad about approving it without reading you could lie about having a fever, then push some weird debug values and see if anyone catches it. That way it's easy to get out of "Oh I was dizzy and pushed too many files by accident...this is why we need proper reviews") -
It's a terrible culture that's very difficult to change. People just click the accept without even looking.
I have tried to show them by my actions that a PR needs a proper review. Through this, I have earned the praise and trust of everyone with consistent proper reviews. Now, they all want me to review their PRs before deploying. -
@jiraTicket I don't really want to, since it will still be mainly my fault.
I am worried about junior devs tough, since they often don't get enough feedback.
Related Rants
Definition of code reviews in our company:
"Part of work that requires you to scroll to the bottom of the page and click accept button. Looking the changes is optional."
rant
code review