11

A dev found a bug I created where I set a SQL parameter name to @OrderID instead of the expected @Order. The standard is @OrderID, there is one stored proc where it's @Order.
Oops...I didn't catch it because the integration test didn't cover that area of the code. My mistake...I should have checked...I take complete responsibility for the screw up.

He let me know by email..
"When refactoring, from now on check the stored procedure parameters, there are a few that don't follow the standard."

I was like "from now on..."? ...wow....bold comment from someone responsible for code that doesn't check for nulls, doesn't log errors, and relies on exceptions for flow control. You wouldn't even have known about the error if I didn't modify your code to log the error (the try..except returned false)

I really wanted to reply ...

"Fixed. From now on, when you come across those easily found bugs, go head and fix it, write a test, and move on. Don't send a condescending email to me, my boss, your boss, all the DBAs, and the entire fracking order processing team. Thanks."

But..I thanked him for finding and letting me know...we're a team..blah blah blah..

Frack..people suck.

Comments
  • 1
    He could have easily said use OrderId instead of Order to you directly. Broadcasting it to others is a sign there may be more trouble.
Add Comment