5

If there's one thing I hate about devs is definitely when they get too emotional about the reviews they receive.

Doing a thorough review always takes significant amount of time and energy. It's about ensuring high quality of code, about functionality and best practices, ... It's also about learning: I learn from the changes being reviewed while at the same time I also try to teach the author as much as possible, giving down to earth opinions.

It's never (or at least should never be) about attacking the author. There really is no reason why someone would spend all this time getting overly personal.

I used to start my responses with (lousy) apologies for being "harsh", but stopped doing this now that my team understands all of this. It also helped asking them to do the same with my changes. The look in their eyes when they find something is simply invaluable :).

Comments
  • 3
    Apologies probably makes it worse! Just be factual :) nothing better than "s/should/must" for a code review
Add Comment