Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
Are the filters really named filter_1 or do they have descriptive names?
If they just count up and always are filled from the beginning I would lean towards the first one.
But if they are named, like ”name”, ”size”… I would create a class with properties so you create a filter object and pass that.
That way you can have defaults, only need to fill out the ones you need, order can be as you want and you can have named filters preprepared. -
@ElectroArchiver
It is PHP in the concrete case, but the principles are applicable in many languages -
@Voxera
That's an really nice alternative aproach, I like it. To answer your question : no, the names of the params are descriptive I just used this for potentially faster reading =]. One of the downsides w/h ver. 2 is when you not always use all of the params and you need to fill only the n-th 1 or 2. In that case you should know/count how much false ones to put before the one you need. -
@We3D what voxera said.
A simple DTO can solve this easily...
Keep it simple - do not try to mix OOP into it, a plain old PHP object with public properties is sufficient. -
Even in c# there are cases you can pass in a parameters array I don't like that personally I like strongly typed prototypes so when something changes it breaks the build
That's my issue with things like js
Sometimes someone changes something and you don't see it breaks till it breaks because it's buried
At least in vs i can try to avoid this by checking all uses but if something is composing the call dynamically I might miss it and the boom the in prog dies
We had a dispute @ work yesterday on this topic :
aproach 1 :
$res = getSomeData( [ 'filter_1' => 'str_1', 'filter_2' => 'str_2', ... 'limit' => 10 );
with
function getSomeData( $data )
{
...
}
VS
aproach 2 :
$res = getSomeData( 'str_1', 'str_2', ... 10 );
with
function getSomeData( $filter_1 = '', $filter_2 = 'default_str', ... $limit = 20 )
{
...
}
I had used 1-st b/c IMHO it's more dynamic and easy to maintain and call ( especially when there are many params, most of which not used on each call )
and my colleague didn't liked it w/h his main arguments that one can not easily see the needed params and no default vals for them ( the latest could be easily corrected in the function body ). I'm curious to read your opinions, arguments & contra arguments for each aproach
rant