Details
Joined devRant on 7/15/2022
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
-
@greendev if it helps It's not types it's contracts, that's why type A with the same properties as type B are interchangeable. Then again, I've never been insane enough to do explicit typing for everything in Vue, also haven't used it in years 😅 (type inference is generally pretty good, and I can see the inferred type in intelij)
While any might get you chewed out, try unknown, or look at some of the meta types like Parameters<typeof annoyingFunction>[0] or using generics?
Hope that helps -
@Demolishun that can still get you the "why didn't you add a comment?!??"
-
@jestdotty The problem is not the detail as far as I can tell, if I don't mention that I didn't do B, then the question comes of “why didn't you do it like this <B>”
-
@jestdotty I love having conversations about code/tools/methodologies/I think this would be cool, and have had them. The problem comes in when they choose to disagree with a sentence you said in the beginning, even though you address that direct concern in the next sentences.
e.g. This fixes problem X. It does it by doing Y. Considered doing it using A, B and C but problems QWE meant Y was the only feasible solution
"Why didn't you do B"
I do appreciate the conversation, what I don't appreciate when it holds up a PR for 3 days (human testing only happens post-merge 🥲) that sales is champing at the bit to get to customers/demo to CEO -
@jiraTicket I agree with the sentiment, but it has only happened once in the ~5 years I have worked with him (the colleague who made the error).
Also the commit message not the PR message
Since you need to select the files to commit manually (mouse) first (or if you right-click on a file and choose to commit, it will focus and highlight the full input field). AFAIK you can't hit commit without manual mouse input (or tab over when you have the input in focus). It would be nice if it showed a warning though if it detected no input -
@jiraTicket It's quite easy to disable (intelij's settings are fully searchable) but I imagine they have it as the default because most people don't care too much about the message. You can even get their AI package to write the commit message for you, and if I had to deal with him too often, I'd be tempted. Luckily, he doesn't/stopped touching the (normal) codebase I work on
-
Oh and squash and merge is enforced, so that commit message is "lost" anyway
-
This one has complained at a retro about "useless" commit messages because a colleague accidentally re-used the same commit message from a different branch when fixing a typo (intelij defaults to keeping the last message in the commit box)
-
You had me at React