SkillsKotlin, PHP, TypeScript Quarkus, Spring, Laravel, Vue.js, React Terraform, AWS, GCP
Joined devRant on 7/12/2017
Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple APILearn More
How do you guys deal with PRs where things just don't go in and you're always making the same comments and suggestions?
We have a fairly experienced guy in the team who doesn't seem that familiar with the language (Kotlin), despite having now used it for almost a year. We're constantly making the same comments on code not using the correct syntax (basic things like val vs var) or following the style guide and after a lot of grumbling the changes are made, but the same issues are present in the next PR.
He also keeps doing things their own way, even if as a team we've reached consensus on a particular design pattern to follow, or way to solve a problem. When you mention this, you just get a "Hmm okay" but nothing changes. It's like things just go in one ear and out the other.
Even as the reviewer this is really frustrating and demoralising. PRs have loads of comments which makes you feel like you're being picky, and they take forever to get approved and merged.
I even often find myself effectively feeling bullied into approving once most of the main comments are addressed, because you're talking the brick wall that isn't yielding - and none of us are happy with the quality of the code going in. A couple of us are even starting to think "I'm just going to have to accept this and then fix it myself later", which is just not a healthy approach.
Now I'm blessed with an amazing manager who is well aware of the problem and knows from his own experience that this guy is genuinely problematic to work with. We're working towards a solution but I was wondering if anyone here has had a similar experience and how you worked towards solving it?
I'm a little at my wit's end :/9
Sometimes, I really fucking hate Windows.
Having trialled Linux for a week on a spare HDD, I wanted to move to a proper dual boot with Windows on my SSD, and I decided I may as well downgrade to Windows 7 at the same time (10 had started to really annoy me).
Booting into the initial USB yielded an unresponsive mouse and keyboard. Hmm, not a great start. Turns out the Windows install USB doesn't like the rear USB ports or the wireless mouse. Strange but plugged in a spare USB mouse into the front and could install Windows.
This install was very unhappy about not having SP1 - to the point where I couldn't even install the network drivers so I could download SP1. Fine, I just downloaded an ISO with SP1 on my Mac.
Then I discovered that you can only really make a Windows USB with Windows. But I've just removed both my Windows and Linux partitions so I can reinstall them ...
After hours of searching and trying to create a bootable USB on my Mac, I finally give up and install a trial of Parallels. So I ended up using the same ISO to install a VM of Windows on my Mac, so I can create a bootable USB, so I can install Windows on my desktop. Well done Microsoft ...
And then I needed to install various drivers for the install to be even remotely useable.
To top it all off: Linux just worked. The keyboard and wireless mouse worked when installing. I didn't need to do any additional set up to be able to use it all. It can even use all 3 monitors, rather than just the 2 that Windows recognises for some bizarre reason.
Thanks to Windows being special, I've lost a day of productivity 😡16