Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
Lensflare1664021dHang in there!
Wait, no. Refuse to review unless it’s a PR dedicated for reformatting only.
Mixing features and formatting in a single PR should be a crime! -
asgs1156721dAnd while you are reviewing, the Author rebased from the ever developing main branch and pushed more commits affecting the files you reviewed already
-
retoor1034921d@netikras not a bad idea, do that and put more focus on manual testing. Make an exception
1000 files. You changed programming language? 😂 What kinda change is it? -
lorentz1509121dWe've been working on a PR for a year that moves every class in the application into a new namespace.
-
nosoup4u204821d@spoiledgoods I mean honestly, yeah. If you can't submit a small and focused pr, don't do it at all. One of the few times where meetings aren't superfluous is when going over a refactoring commit
-
lorentz1509121d@Lensflare unfortunately C# allows retrieving type objects by qualified name, and evidently if it's possible we should do it, so we do that quite a lot.
-
@nosoup4u it's standard practice on my team to reject large PRs by default and I wouldn't have it any other way. at a certain point it's about respecting peoples' time (unless it's a critical change or something)
-
devJs132619dWhat's this? Rebase gone wrong?
I mean I'll rather just write a new app at this point!
One does not simply make PR after half year of pushes!
Only 1000 files remaining to finish reviewing this PR. I'm almost there!
rant