36
ddephor
6y

The guy where I can only shake my head when I see his code, and he is really proud of if implementations, while he

- doesn't care about warnings

- breaks builds and doesn't care

- doesn't care about code styles and indents in a very column based way

- adds tons of comments to his code, mostly hard to understand, and sometimes that much you can hardly find the code

- implements a tokenizer where you have to inherit from its interface (Why would I wanna implement whole functions for a tokenizer and not just use it in place where needed? How do I use two of those in one class?)

- implement a "generic" state machine base class with fixed lengths array of 3 events and 3 strings (Why would I need events and strings hardcoded in a "generic" state machine? Why a maximum of 3?)

- once delivered a software without the needed runtime components, so the whole system (embedded device) wasn't working properly and only by chance missed the point of disabling update mechanisms

- make your ears bleed about his big inventions whenever he sees you, no matter how often he already told you about that blazing new feature

Comments
  • 3
    Sounds like you could learn a lot from him 😜😂
  • 3
    I never read the warnings.... Just the errors
  • 1
    @PuzzlesDev Yes there is a lot to learn how not to do it...

    But the main problem is that we don't have any feedback system and few coding rules are not enforced. So I can point to the rules but if he doesn't care, I can not do anything.
  • 0
    @billgates Warnings often point to errors or problems that may lead to incorrect behaviour. You'd better read your warnings.

    From time to time I use -Wall and every time I do it I find some bugs that just haven't shown up in production.
  • 0
    @ddephor most are syntactical or unused variable...

    Yes I know it's unused... I'm working on it...
Add Comment