5

This code a (much more senior) co-worker wanted me to review...

Comments
  • 0
    Infinite loop anyone?
  • 2
    @DeepSpace no, because the break at the end. But the for-loop-condition doesn't make sense now. You could've easily mapped headers (and you should pass it as parameter i think) via a lambda and a ternary operator. Done.
  • 4
    That != just gave me cancer, diabetes and smallpox simultaneously
  • 0
    @sharktits intellij does that, it's actually a "!=".
  • 0
    @Brosyl 's ligatures bruv
  • 0
    @Brosyl 1. It looks amazing
    2. Because of 1, it's much nicer to read
    3. A lot of the symbols that we as programmers use start to make more sense, like how != beomes an inequality sign. Or -> becomes a proper arrow. Or === beomes an actual mathematical identical to symbol

    https://github.com/tonsky/FiraCode/...
  • 0
    @Brosyl lol I don't see the need either, but it looks a little better.
  • 0
    @Brosyl that's just personal preference. I like it, so I use it. Turning off the ligatures is a matter of unchecking one checkbox (intellij) or changing one config entry (Vs code)
Add Comment