13

Finally had the time to finish the notification filter, also made the download instructions much simpler than before

Had to remove the unread notification dots, because else I simply didn't have enough space and everything else just didn't seem right

The script also solves the issue where the notifications don't get marked as read once clicked and adds an "unread" tab

https://github.com/7twin/...

Comments
  • 0
    @Floydian
  • 0
    @Floydian done 😉
  • 0
    @Floydian yeah have it on the todo already, the button was a bitch for no reason 😅
  • 0
    @Floydian btw the clear button isn't mine just yet, it's still the devrants one, thinking of replacing it now, thanks for the idea
  • 0
    @Floydian ahh I probably didn't call the reset in the listener, great catch!
  • 0
    @Floydian that's a weird one, since I don't add the notifs in myself, I'll try to reproduce that today
  • 0
    @Floydian
    I'm glad you did, thanks 😊
  • 0
    @Floydian hah, will do
  • 1
    @trogus
    Done , i guess...
  • 1
    @Brosyl Lol. Brilliant 8)
    @Floydian "breaking the code" somehow makes me think of WW2.
  • 0
    @Floydian oh, so you ARE gay 😁
  • 1
    Added to awesome-devrant
  • 0
    @Floydian ah slash does that, I'll include that in the match, thanks!

    @Brosyl tbh I tested it only on chrome, since tampermonkey usually ports across all browsers equally, I'll see if I can include the option myself in the code body too, probably some race condition, even though I overwrite the click event

    also don't worry the "spam", I am very happy about you guys finding bugs, so I can fix them :)

    @Skayo Thank you!
  • 0
    @Brosyl Tampermonkey should automatically update the script now, I addressed your issue by including the run-at header, hopefully that fixes the bugs, if you still encounter any issues, please tell me

    @Floydian fixed the url issue, will look into the others too
  • 0
    @Brosyl hm, nevermind, just checked on firefox and could actually reproduce the forkbomb style new tabs, I'll see what causes this 😅
  • 0
    @Brosyl interesting, because if I test it on my firefox build it still does it lol
  • 0
    @Brosyl found a fix for it, will push it shortly, weird that it works for you without it
  • 0
    @Brosyl the default should be already document-end iirc, so it surprises mes that I still have to set it
  • 0
    @Brosyl another thing I noticed: I was wrong, the default update checks of tampermonkey are set to "every day", so not everybody immediately gets those, as soon as they are pushed to repo
  • 0
    @Floydian fixed now also the issue where the tab would still display unread, even though all notifications in that tab have been read
  • 0
    @Brosyl ah, good that you did, still weird to me how it works without the newest patch
  • 0
    @Brosyl well I actually did, still didn't solve it without adding the patch haha
Add Comment