7
donuts
6y

Not really a fight but another Dev was telling me how I should implement things and to keep the code clean and clear/not spaghetti.

In the back of my mind I'm going yeah... I know what I'm doing... probably better than you.

I'm usually the guy telling other ppl to clean up their shit..or forced to dig thru it when their stuff blows up in production.

Anyway I'm going to add him to code review and maybe email the whole team... and then go, now this is how I want our code to look.

Comments
  • 0
    I don't understand your mentality

    Im not so great so you're probably better than me, but sometimes my PRs get upwards of 20 comments and I learn shit loads every time.
  • 0
    @craig939393 well my PRs never get comment, they just get approved.

    I comment on other people's PRs.
  • 0
    I realise this is a site for rants, but I'd file a debt ticket on that attitude. It's a huge red flag for an oncoming burn-out.

    Take good care of yourself. Don't let that garbage run around in your head.
  • 0
    @bezorp what's a debt ticket and who you aiming at?
  • 0
    @bezorp not sure what you mean by attitude.

    I was more like "yes I know what you mean, I was going to do something like that anyway and actually do you one better".
  • 1
    @billgates my bad. I read it in to it all the wrong way, then.

    I definitely know the feeling you're talking about.
  • 2
    @craig939393 pardon, was aiming at @billgates, but turns out I was mistaken.

    A debt ticket is a ticket to address technical debt.
  • 1
    @bezorp I'm probably the only person in my team that has used the term technical debt. And again I'm the one that has to clean up other ppls shit... And usually after they've left.
  • 2
    @billgates I feel your pain. I just started a new job, and it's been the first place I've worked where the entire company, right to upper management seem to grok that technical debt is a real thing, and that it needs to be paid back.

    When our CTO gave a speech to the company saying addressing it was a real priority and how we were "coding scared" right now, I nearly cried.

    I'd like to think that this reflects a change in how "IT" depts aren't just a box of wizards you shove tickets into, but a group of employees who actually care about the overall hygiene of the source code they spend the majority of their time working in.

    Even if you can't get management on board, I'd strongly recommend getting your fellow devs on board with the concept. Then at least you can present a unified front when you get tickets that will take 10x longer, just because of all the kruft that's accumulated from sprinting to grab market share.

    Sorry got the wall of text. Pretty passionate about this. 😝
  • 0
    @bezorp well on my last team, before I transferred I basically owned 50% of it, all the frontend apps and servers) I became the sole Dev after 4 ppl left.

    I cleaned up a lot of shit in the code and automated release and testing so but the time I left the only thing I needed to do was:

    -Make a change
    -Click Deploy to uat and test
    -prepare automated regression tests cases generated from an app I wrote that parses the request logs from all our servers
    -Give it to Support for Prod release
    -they install and run the tests against Prod

    So yes I'm the guy that wants about technical debt and inefficiencies in our code like how **** does this tiny report take 20mins to run.

    Who the f*** hired this monkey...
  • 1
    I just left a job where running tests on the backend took 30-40 minutes to complete. Do some BE work - oh I'll run the tests before I merge. I'll just go have a nap.
Add Comment