22
dfox
9y

Having to check a 5,000 line PR makes me sad :(

Comments
  • 2
    Big code cleanup/removal. Not as bad as it could be since at least it's removing code rather than adding but should still be broken up! But in the past like you said I've gotten them for library swaps and stuff like that. By far the worst is when it's in the form of an entire project or feature. Small PRs FTW IMO!
  • 2
    I want a tool which can make such big PR reviews easy to review Visually. Github kinda sucks when number of files changed increases!
  • 1
    commenting on a really old rant i know but just to say, one of my colleagues opened a PR recently called "project cleanup", removing over 2,000 FILES :'D
Add Comment