Learn More
Resend Email
32
oztek
6y

my team mate thinks that function name should be descriptive so you can understand what It will do.
Here are the examples of functions he created:

createArrayOfConsentChangedEventObjectForAConsentForAllDataProcessorsWithoutNameInEvent()

createArrayOfConsentChangedEventObjectForAConsentForAllDataProcessorsWithNameInEvent()

createAndPushConsentChangedEventWithAndWithoutNameForAParticularConsent()

I was supposed to review his code but this names are so annoying that I gave up on reviewing and just passed his code since functionalities were working as expected. -_-

Am I the only one who gets annoyed by long function names?

joke/meme

time waste

rant

js

fml

random
Favorite
Ranter
Comments
  • 13
    6y
    Yes to creating a good, clear and describable method naming

    No to what ever the fuck he/she is doing
  • 6
    6y
    I'd tell him to fuck off and write that shit into the docs. Choose a name that be spoken within one normal breath.
  • 3
    6y
    @Awlex exactly my point. That co worker is a good frnd of mine so I shared link of this rant with him so dw, he will get your message 😂
  • 1
    6y
    In the language I programm, the limit of all names (classes, methods, variables) is 30 chars and this is also sometimes really annoying. But you get very creative to find good names...
  • 1
    6y
    Overdoing something is a problem too bro.
  • 0
    6y
    OMG! WTF?!
  • 0
    6y
    I’m ALL about descriptive naming conventions... but this is beyond verbose.
  • 1
    6y
    Has (s)he added comments to each one of them too, if the answer is yes, then there's no excuse for names to be so long. There should be no more than 5 words in a single method name, otherwise it becomes too long to read and understand. That's why comments were invented to add description to the code. Also did he ever hear about polymorphism and/or overloads? Such long names make it impossible to work with if he writes polymorphic code and/or uses overloads.
  • 1
    6y
    Ask the dude to use snake case if readability is the objective.

    Camel case is for 3 words at most. Generally.
  • 3
    6y
    Joke's on you because you're going to have to maintain that code. I would NEVER approve that.
  • 3
    6y
    Like @muliyul said, since you approved it, you're just as guilty.

    What I would have done :
    talk to the guy
    Put up a linter and a variable / function name limit
    Asked him to fix every error

    Alternatively : go nuclear
    Write your code in a single function name then parse & eval the name.
  • 1
    6y
    @Commodore I like the second option 👹
  • 0
    6y
    Function names shoild be descriptive for sure, but these names are too long and it is a waste of time and a hassle to read. Ask him to use shorter names and do some code comments to explain the functions, this is how it is supposed to work ...
  • 1
    6y
    @Commodore 🤣🤣
    Third option : teach him abojt code comments, code docs and descriptions
  • 1
    6y
    @Debugmed that's what I had in mind by "by talk to him". (which is quite ironic : being too vague in a rant about someone too explicit 😋)

    Anyway the idea was:
    1. Teach
    2. Setup safeguards
    3. Put in practice
  • 0
    6y
    @Commodore good luck 😋🤞👍
  • 1
    6y
    Maybe tell him about comments?
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment