What is the worst thing you have encountered in a code review?

  • 8
    My own comments
  • 0
  • 5
    My own code D:
  • 7
    Total absence of whitespace.

    (I fired them.)
  • 1
    @Root minified code?
  • 9
    @delc82 Handwritten, unfortunately. Worse than intern level, and yet he called himself a junior dev. He didn't know minifying was a thing (or that build tools of any kind existed at all).

    The only spaces in his code were in strings. Everything else touched the left margin. No blank lines either, and he defended all of this saying it was easy for him to read.

    Also, no loops of any kind. To repeat the same action 8 times, he copypasted the code 8 times.

    It was his second (and last) code review.
  • 1
    @Root wow I never met a dev like that.
  • 1
    Code itself
  • 0
    @Root Was it all on one line, though?
  • 2
    I actually can't make up my mind... Two things from a former coworker (with a master in computer science!) popped up when I read your question.

    A) A VB program without loops. He really copied the same line ten times and modified the one value by hand. Four times!

    B) A C++ program that was actually a *demo* from the Centera API documentation, slightly adapted. It was a mess of a dozen "if (foo())" - lines, making the code wandering to the right.
  • 1
    @electrineer *twahaha* that would be fun:
    "Syntax error in line 1"
  • 3
    @electrineer Nope. If it was, I would have assumed it was minified.
  • 1
    @Yamakuzure I don't understand how those people passed the coding test to get the job.
  • 4
    @Hubot-0x58 haha I did. I gave him a list of things to fix and things to learn, e.g. for loops. He didn't. He was basically a complete newbie to development, and I didn't have the time to teach and handhold. I had projects that needed doing and not enough people to do them, so letting him go actually improved our productivity.

    I used to hold free classes to teach utter beginners, and much of their code was better 😅

    @delc82 Neither, unless there wasn't a coding test at all?
  • 2
    @delc82 He was a brillant project manager. But that wasn't what he was hired for. Got fired in the end due to incompetence. 😕
  • 0
    @Yamakuzure I guess the company didn't deserve him
  • 2
    @delc82 Well, he really messed up some projects and sucked our reputation down a lot with some clients. One of them being Pioneer in Luxembourg.
  • 2
    @Yamakuzure darn man that's heavy
  • 0
    No assertions after reading from db. List.size() - 1;
    And he was done.
Add Comment