Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
As long as you need to review it. Depends on how much it is and how complex, and whether it's enough to review diffs or a full review is required.
Also, what's the purpose? Checking that style guides were kept? Or do you want to find bugs? -
devJs13266ymy team(4 of us) has code review daily meeting first thing in the morning. we briefly show and comment what we did yesterday. there are questions and discussions about why did we wrote code that way and if we could do it better, constructive advices from colleagues is common thing. it lasts about 20-40 minutes.
for detailed code review we use pull requests that team lead and other web dev on project go trough all the code. we use PR on several projects, on some older projects that we maintain we don't use it at all. it is all matter of agreement! -
C0D4669026yPeople make actual meetings for this?
Just make a pull request and let someone read over it.
This kind of task should take less then an hour at worst unless you’re changing a lot.
Related Rants
-
nikmanG16CS Professor: “What M word is the black hole to all productivity?” Student: “Management” CS Professo...
-
nachocode23If Gordon Ramsay made code reviews, I would watch that show. Especially the insults he would use for handling ...
-
arturgrigio40Google is full of assholes! Just paid $25 dollars to list my app on google play store. Within 15 minutes of s...
How long do you think code reviews should be? Ours can run from anywhere between 10 minutes to 4 hours
rant
scrum
code review
review
meetings