Learn More
Resend Email
5
Demolishun
5y

#define AUDIOLB_EXIT_ON_ERROR(hres) \
if (FAILED(hres)) { goto Exit; }

#define AUDIOLB_SAFE_RELEASE(punk) \
if ((punk) != NULL) \
{ (punk)->Release(); (punk) = NULL; }

Looking through old audio code I wrote. Found these macros. Will most likely reuse for a new project. It works damnit!

Do you feel lucky?!

random

old code

lol

will probably reuse
Favorite
Ranter
Comments
  • 0
    5y
    pointers can be implicitly converted to booleans, you don't need to compare to NULL
  • 1
    5y
    I wanted it to be obvious the test was for null.
  • 1
    5y
    I think you should wrap your macro bodies in a do { ... } while(0) block to avoid dangling else and other potential unintended behavior
  • 0
    5y
    Is there any chance that you can replace the goto statement with something else?
  • 1
    5y
    @offworld or add "else ;" if that's a concern
  • 1
    5y
    @offworld That is an interesting idea. I could slap just some braces {} around it, or put a else{} on the end too. Thanks.
  • 0
    5y
    @orhun I am not sure I can get rid of the goto. I will look into some potential RAII for this.
Related Rants
devRant © 2021 Hexical Labs LLC
Privacy Policy  |  Terms of Service
Add Comment