the Death Valley of PR approval

I have almost 3 years of work experience in programming professionally. Currently this is my second company. Previous company I worked for was very loose regarding clean code, code readability, tests etc. It was their way of doing things fast, making working changes quickly was the most important thing due to its business. Now I work in company where I spend a lot of time in some limbo when my code works and my code is merged. It sucks, I make all kinds of mistakes which would be tolerable in my previous workplace, but now it keeps me from releasing code. I now the way I do things now is the right way and it will result in me growing as a specialist, but it is very frustrating and damages my self esteem. I hope it will pass one day.

  • 4
    The devrant tag is only for stuff about devrant.com itself though.

    There are no "developer rants" because there are only devs here, no finance and HR, so that every rant is a developer rant.
  • 2
    @Fast-Nop sorry, can’t edit now. Have a nice day!
  • 3
    I prefer a process than no process at all. Although, I think a process should not be too rigid that it hinders the progress of the business.
  • 3
    @rantsauce The point is exactly to prevent business progress turning into fast but chaotic.

    In my company, we are really process heavy, but we can bypass nearly all of that for test-only deliveries.

    These only need to be marked as such, be tagged under version control and have a short documentation of the software status.

    The customers will see all the processes followed for the final production software, but they also can be sure that the result will actually work like they want.
  • 4
    My point was more personal. I moved into new company where standards are higher and it can be painful to adjust to. But that probably comes with territory. Just sometimes it hurts to see your PRs returned when you were so happy to manage everything to be working. Wanted to let of steam and wondering how others dealt with it.
  • 5
    @gto3000 It's frustrating at first and makes you doubt your skills in the beginning but it feels really good when your next merge requests receive fewer review points. You will get to the point where there is none or maybe just a few minor ones and you will look back to this day and realize how much you've learned.

    Of course, not all review points are valid but at least for the valid ones, you grow.
  • 3
    @rutee07 thanks, some days you need someone else outside of your bubble to say something positive and today you did it for me!
  • 2
    @gto3000 you are right. It was very hard for me at the beginning as well.
    But guess what? You will become better and less affected by each PR you get back. Always remember its not personal and it doesnt define who you are and what you know. However, what you choose to do about it or how you act upon it means more more.

    It is expected from junior devs in companies to get PRs back quite often, its part of the learning curve.

    In a year from today youll be a much better dev and your PRs will be solid. Even when you'll join a new repo and a PRs might get rejected, you wont take it personally at all.
Add Comment