Do all the things like ++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatarSign Up
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple APILearn More
Suddenly, some of the stuff I've seen doesn't feel so bad anymore
sariel89092yThat's when I would start looking for another job.
Holy shit, the hypocrisy is unpalatable.
Hazarth86122yWho cares how Its sorted, as long as Its sorted so related packages are next to each other it shouldn't matter.
Pointless standard, and retarded people needing validation
iiii96072yFuck them. Get out of that team
What a dumb assturd
user00015422y"their 18+ page coding standard document that all the references in the 'using' block be sorted alphabetically"
What the fuck?
I get that it's easy enough. But the point is that this is both arbitrary and worthless. You might as well demand all functions be in alphabetical order, or all properties be in alphabetical order (which is almost reasonable!). But using/import statements?
Find a new job yo.
korrat6602y@user00015 if you have an automated code formatter, it should be easy enough and acts as a brown M&M check. That part I find reasonable enough.
However, I'm put off by the apparent lack of automation. Code formatting is easy enough to check in CI. Or in a pre-commit hook for that matter. It should never be necessary to bring that up in a code review.
Of course, then there's their disgusting behavior. Nothing could excuse that.
I really dunno in what SM / Psycho-Terror company you are working... But this is really terrifying.
Code Styles must be automated.
There is no if, no but, no except.
Either automate or let it be.
If a simple linter cannot understand what the coding guideline does, a human will not be able to do it, too...
For the behaviour, I as a manager would give HR a hint that someone is ready for either extended training in corporate rules or getting fired.
There's a distinction between mobbing and doing review ... this is definitely mobbing.
Which pisses me off.
Fuck the wankers with an anchor... *Hums Alestorm*
@user00015 > "Find a new job yo."
Luckily, the administration responsible for the absurdities were fired+quit several years ago.
Code reviews are now only peered reviewed by people closest to the problem (ex. other members of the same team) and 99% of the time it's only sanity checks. Look for n+1 patterns, hard-coded passwords, make sure errors are logged errors. etc. Nobody cares that there is an extra space between methods (yes, spacing was a *big* issue with the previous admin)
We use Azure DevOp's code review features, so getting feedback on check-ins nearly eliminates folks looking for attention. That's another TL;DR story.
@iiii > "Get out of that team"
Luckily, the administration responsible for the code review absurdities were fired+quit several years ago.
When 'Toby' left, the manager re-assigned me to his position. One of my first (of many) tasks was to delete the code review document from the intranet.
Who the fuck cares about sorted usings?
Sure, I do that for myself from time to other but i would feel like a total dick if I were to put this in some code quality document or reject PRs because of it 😂
@ReverendLovejoy > "i would feel like a total dick if I were to put this in some code quality document"
Yea, when I was 'promoted', one of the many improvements was deleting that section.
I ended up deleting so much of the document, the new department mgr removed it from our document library.
We currently use SonarQube and it's metrics to improve code quality.
If the standards are this rigorous you should be forced to use some auto format plugin or maybe a commit hook!
Pretty tiresome to force people to alphabetically sort manually (its good enough for most but if you start having meetings and shit about not doing stuff it needs to be automated as much as possible)
As someone who sorts and groups my import statements according to a dozen different rules like I have OCD, I still think it's ridiculous to make others do that.
It literally adds nothing to the code. Just makes me feel happier looking at it
sariel20Simple 1 day task. This idiot takes two weeks and after 7 days of hounding finally opens a pull request. I go...
PaperTrail19My code review nightmare part 3 Performed a review on/against a workplace 'nemesis'. I didn't follow the depa...
NickyBones21My code review nightmare is reviewing C++ code that was written by Matlab people. Letting them commit code wit...