Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
I think a good approach is to not just show WHAT is bad and WHY, but to show and discuss about better approaches and bring in some real life examples why these improvements actually help everyone in the team.
A good example is readability:
Writing big methods with complex instructions and long comments will make it harder for a future coder to understand what it does.
Or cosistent formatting:
It makes code look similar, independent of who in the team wrote it. It feels more familiar to everybody and thus more maintainable and simpler to understand. -
dan-pud8593yConstructively
Refer to any coding standards your company has.
Provide examples where something could be better.
Provide positive comments as well.
Try and make it a conversation. -
@Benutzername the way my managers have taken my code review is by nitpicking issues which didn't seem like issues, at times asking me to completely change the system. I'm not saying they were always wrong, but it left a bad taste in my mouth. Now, I don't wanna do the same, so I want advice on how to actually approach it.
-
Crost41083y@LOLjustCoding if we rewrite this as an enum would we be able to get rid of these magic strings?
-
Crost41083yThat said in my experience people don't want feedback, no matter what you do they will either get pissed off or ignore you. So I lean into it. I once left 120 comments.
-
atheist98263y@LOLjustCoding "nitpicking issues that didn't seem like issues" to you. Maybe that's a difference of opinion, but bear that in mind and try to explain why you think something is an issue. Coding standards are really good here, when you can just point to a document that says "do it this way".
-
asgs115633yLOL. You are just coding, man
Keep your comments coming as long as they make a good difference. It is up to them to consider working on those comments -
atheist98263y@asgs I dunno. Pre covid, I'd sit down with them and go through everything, particularly with junior devs. Now it's just "You've received an email: some bastard has left 50 comments on your code", feels a bit abstract and dehumanising.
-
asgs115633y
-
Hazarth94743ywhat the others said is the best way:
just be constructive and link any references you used to support your arguments.
in cases where you're voicing a subjective opinion (like code style) you should check how it's done on other projects in your company, so it's consistent. In case there's no precedence to what you're discussing you need to explain what your reasons are for the change to be made.
In subjective cases, be open minded too, the reviewee might come up with better reasons to keep his style or solution and you have to stay objective about how important the issue really is.
especially with tiny nitpicks I like to message the guy saying something like" hey, I didn't find a lot of major issues, mostly just tiny points or questions, I'll leave the decisions up to you in case you disagree" or something similar.
Important to remember that your job as a reviewer is to hold your teammate's back, you're there to spot bugs & mistakes early and that helps the entire team. -
uh... code reviews are usually very neutral as far as feedback goes, but a general rule for feedbacks: be specific and clear, don't spare words if it might compromise their understanding
Related Rants
-
nikmanG16CS Professor: “What M word is the black hole to all productivity?” Student: “Management” CS Professo...
-
nachocode23If Gordon Ramsay made code reviews, I would watch that show. Especially the insults he would use for handling ...
-
cdrice32This code review gave me eye cancer. So, first of all, let me apologize to anyone impacted by eye cancer, if ...
What is the best way to do a code review for a colleague's code, without coming out as a complete ass?
question
code review
management