A PR I raised was left un-reviewed for 3 months. And finally when shit hit the fan, I was asked why I never worked on the fix.

I pointed to the PR I raised 3 months ago and I got absolutely flamed for it because obviously, it was my fault that I did my part, asked for a review and moved on to other tasks.

According to my manager, I should have kept pushing for the PR to be reviewed.

I wanted to set the office on fire that day.

  • 9
    Had similar issues in my team.

    Turned out there were lots of unspoken expectations from managers that the dev team had the responsibility to ensure important PR:s were merged. We asked "what about all the new tickets you're assigning us to?" and they said "we want you take charge and remind us that maybe new tasks need to be put on hold in favor of reviewing PR:s"

    We had a meeting about our Ticket Board and "working agreement".

    most of these PR problems were resolved by adding an "in PR"-column synced to github so that it became obvious during daily meetings which tasks had been in PR for too long - and we all would prioritise those.

    But to some extent it was a misconception that we expected management wanted us to quickly move on to new tasks all the time - but we actually had the mandate to halt the team and demand that an old PR was merged as a top prio.
  • 6
    What's your software lifecycle say? If there isn't one (or it doesn't cover PR ownership) then there was no procedure you didn't follow.

    If management wants you to follow a procedure, they need to do the honor of telling the team in writing.
  • 6
    We currently have some +9 month old pull requests :')

    Always fun to have your work wasted.
  • 3
    Tell your pm if managing people is your job, he better gets good at coding fast
Add Comment