18
tahnik
7y

It would be nice if you could star the repo if you are forking it :(

Comments
  • 1
    Well the one I forked actually ended up rewriting a lot of the code...
  • 1
    @billgates Pull Request?
  • 0
    @tahnik nope, cuz then that'd be like giving away all my work under his name. I was thinking of unlinking the fork tbh
  • 0
    @billgates would that be...ethical?
  • 1
    @tahnik unlinking? Or taking all the credit? #2 well that's how the real world works...

    In my mind you PR bc u have something to improve their code, not bc u rewrite the whole thing and implemented 90% of the functionality it needed
  • 0
    Both I think. Depends on the rewrite. If you are rewriting the whole thing, then it makes sense to just put it under your name.

    But if you rewriting and keeping his structure, he still deserves credit. I do agree that you should not PR if you added major functionality unless it's an open source project where community builds the project.
  • 2
  • 0
    I never star projects unless I want to find them back, what is a reason I should star?
Add Comment