112
Comments
  • 4
    This is my life soon
  • 9
    I stopped being selected to participate in group code review "bash sessions" because my comments were:
    "Looks good"
    "Add some exception handling here..."
    "I like what you did there ..."
    Instead of..
    "This is the worst thing I ever saw ..."
    "If you knew how to code correctly, you would have written it like ..."
    "OMG, you need to re-write this whole fracking mess."

    My acceptance criteria is simple. Unless it would/could cause a problem for user, or result in high technical debt for a future developer, its fine.

    When one of the devs who was a center of these "code reviews" was promoted to a manager. He stopped the practice and now we do mostly peer reviews as the code is be written/developed (long story behind that).
  • 1
    @PaperTrail as you said, you need to know to make it the right way... Unfortunately there is more people making it in the "wrong way" or with the "wrong purpose"...
Add Comment