3

Nothing says asshole like a guy who won't approve your MR even though the feature is working but they prefer implementing it using their preferred approach.
Different coding styles for different folks. What matters is that the approach used is efficient, working and tested. But oh no, you have to write the code exactly how they want it.
Good thing we're free to merge our own MR when the reviewer takes more than two days to merge it.

Comments
  • 1
    they should rather tell you the reason behind their styling (scalability, maintaince, etc) and ask you to update PR. its stupidity and extra effort on their end, so you don't worry and rather relax that you are being paid to not add any code
  • 4
    If there are valid reasons, fine.

    If it's snarky: Do it my way or else, fuck off.

    That said, compromise should always be an option. Just merging is the same snarky way of saying: Hah, too bad, I ignore your opinions, merged it - luckily you're such a slowpoke.

    ... Which really doesn't improve the situation at all, cause now it's not about writing good code, it's just about pissing off each other.
  • 1
  • 0
    It could be legitimate if it serves consistency
Add Comment