Dear managers:

Don't rush developers when they're reviewing code - telling them to cut corners.

You're not a dev (anymore). This shit is important if you want a system that doesn't blow up / takes months to make a simple change.

It's my name going against this approval and I (and the team) have to live with the code every day

Stop pissing in our garden

managers rush every aspect of software - not just reviewing. Requirements gathering, documenting, developing, testing, QA everything is rushed most of the time.

The one parasite software engineering has is called a deadline.

@SidTheITGuy and they are right to do so. To maintain tension on both sides of the scales: code perfection and revenue created / market share attracted

their job is to hurry. Our job is to try and hold them back to have time to make the code somewhat maintainable

@netikras Yeah I agree. And there is an art of doing so - you don't want to look like you're denying the deadline neither you want to look like you're giving in to the deadline.

Sometimes you get verbally abused or gaslighted if things go beyond a line.

But that's what we sign up for, I guess.

@MammaNeedHummus show teeth!

Depends in the higher ups. My manager have been chill for since I started the company.
The past 2 months, the company has been in talks of being acquired by some bug corpo and he is being rushed by higher ups which leads to me and to finish the tasks faster.

He tried to fight it but to no success.

Especially the back and forth on comments, do they take that into consideration?

100% correct: if you approved it and there's a fire, you can't blame it on the manager.

But that being said - sometimes a manager will ask for a review to be sped up.

but all they really mean is it should begin now. It's fine if it takes time. But let's not have it lay unreviewed for 4 days.

This can be important to clarify in a team with many open PR:s

@MammaNeedHummus but what if your garden is a dumpster behind a bar?

@Wisecrack noone likes a flaming dumpster full of piss

Flaming dumpsters of piss all day long. When can I retire?