Worst code review experience? - devRant

Ranter

Comments

14

olezhka

2572

7y

That's deep. Or shallow.
8

infinite-lifes

195

7y

I mean, it kind of makes sense. It shows, that getting null here is an expected behavior, but it's a special case that needs to be handled separately.

Expressing intent is much more important than brevity.
7

beggarboy

2158

7y

(value == null) ? return null : return value;

There you go.
26

olezhka

2572

7y

@beggarboy how about return value; ? #smh
5

QueenMorgana

14097

7y

Are the lines all aligned because that's how the programmer did it, or because you did it because that's easier than aligning them on the phone for ranting?
3

olezhka

2572

7y

@QueenMorgana hope the latter
5

QueenMorgana

14097

7y

@olezhka That's why I'm asking. I really hope it's the latter
12

sSam

1483

7y

I can't believe there's even a discussion about this.
7

klonky

257

7y

@sSam I can't belive i read the discussion till the end.
1

just8littleBit

4809

7y

Eww
2

awnumar

283

7y

@infinite-lifes lol no
4

Zulukas

18

7y

I understand that this is a silly block of code that could've just been "return value;", but the "if (null != value)" just makes so irrationally angry. Make it "if (value == null)".
3

Krokoklemme

4459

7y

@beggarboy if you want to use the ternary operator in a return statement, at least do it properly:
return value == null ? null : value

But @olezhka is right, just write return value;
1

freeme

801

7y

Wtf, I’m so confused

Related Rants

devRant © 2021 Hexical Labs LLC
Privacy Policy | Terms of Service