Ranter
Join devRant
Do all the things like
++ or -- rants, post your own rants, comment on others' rants and build your customized dev avatar
Sign Up
Pipeless API
From the creators of devRant, Pipeless lets you power real-time personalized recommendations and activity feeds using a simple API
Learn More
Comments
-
You are saying that it's a refactoring job, could it have been written at a time when async/await or promise patterns were not established yet?
Admittedly even then it could have been done better. -
curlyDev4726y@rusty-hacker but thats waaay too much. At that point it feels like deadlines were way closer than reason was.
-
If he doesn't know how to use promise, he should at least know how to make a variable containing a function to keep it DRY...
It's a basic understanding of JS... -
BranDev1346yI hate deep nesting. There are some programmers who really love it though. To me it just lacks any real clarity, and it makes the code brittle. If I had to refactor this, I would try to flatten this as much as possible. IF that's even an option. I'm not a Javascript dev, so I don't know
-
perotti7986y@BranDev the worst part is they don't even depend on each other, so we could await Promise.all([]).
But I'm not touching this. 🤢🤢🤢🤢
Related Rants
-
sugoi18Since past two-three years, Indian Government has been organizing a Hackathon called Smart India Hackathon for...
-
IceFreak20003After months and months of unrealistic deadlines, pulling late night shifts coupled with an insane commute and...
-
linuxxx6Was writing a first product for my best friend and my first company/startup. (that one is on hold now by the w...
Refactoring someone else's code (the dude's a senior).
I'm a junior, just updated my linkedin, burnout activated, I can't deal with this kind of shit no more.
Outro: this is the nicest piece of code from him, every other line of code just .... just.... D:
rant
wk105