20

Time to do a little bit of shaming:

I'm specialized in e-commerce applications, mostly based on Shopware, a german out-of-the-box online-shop. They essentially claim to be a better Magento. In December of last year I found a critical issue within the code. Products within the shop can be declared as digital wares. In that case the purchase of a product will unlock the possibility to download a designated file.

As a customer you can access your downloads within the account section. Now here's the problem: The query that fetches the unlocked downloads for a customer is hard-capped at 500 rows. So after your 500th purchase, you won't be able to access any further files you paid for. Essentially their developers thought that this limit would never be exceeded anyway and called it a day.

Personally I think this unacceptable. For the merchant this is a potential law-suit in the making. So I took the time to refactor the code and fix the issue. The corresponding pull-request was flagged as scheduled back in December. Since then there have been numerous releases and the issue is still present. Not only do I ask myself why I should ever put in time and effort to fix their code again, but I also can't believe that they just chose to ignore the issue completely. Also mind that this is not just a small or non-profit open-source project. The responsible company behind the software is a stock corporation that claims to be the market leader in Germany.

Comments
  • 2
    God, I fucking hate Shopware. I feel you man. The support sucks, and the software itself is the hugest pile of garbage I ever had to work with. Change one file incorrectly, and the whole fucking thing breaks, not even leaving any error message behind. Shopware would just randomly break, as our customers updated plug-ins which where built for that specific Shopware version (signed plug-ins from the store!). "Market leaders" my ass.
  • 1
    The naming convention of those fields is giving me a headache
  • 0
    @bigus-dickus Your assumption is correct. There is a pseudo-pagination in place which is (and I'm serious) slicing the resulting array according to the paging parameters. I fixed that as well with my pull-request, adding placeholders for limit and offset to the query.
  • 0
    @dneustadt i do a lot of ecommerce aswell and I assure you that shopware core developers are oblivious to this and don’t care. It’s great you tried to put your fix out there! Shopware is annoying and the plugin ecosystem is a joke and a cashgrab. I’ve seen so many shops break because they installed two plugins that broke eachother or something stupid.

    Switch to Magento 2 - the community behind it is way more enjoyable and contribution is taking serious.
  • 0
    @AlexDeLarge out of curiosity: what ecommerce software would you recommend?
Add Comment