15

Getting beaten up over the quality of an app i'm working on with 6 interns. We have a bunch of unit tests, was shocked to see so many issues ... until I looked at the tests.

A function returning a non-optional array has 1 check ... that the return value is not nil ... fml

Comments
  • 1
    I've seen this too many times, from 'experienced' devs. Method returns a complex object and the only test is to make sure it isn't null
  • 1
    @linux-colonel ha, like its all stubbed with mock data ... can I get an array count?

    ... at least thats something valid
  • 1
    @practiseSafeHex it's definitely the biggest problem with how devs use coverage tools. Writing useful tests is harder than making sure all the branches are covered!
Add Comment